Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sd-webui-quickrecents #379

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

MINENEMA
Copy link
Contributor

@MINENEMA MINENEMA commented Oct 22, 2024

Info

Small UI addition to view recent txt2img/img2img generations and copy their generation parameters
https://github.com/MINENEMA/sd-webui-quickrecents

Checklist:

  • I have read the Readme.md
  • The description is written in English.
  • The index.json and extension_template.json have not been modified.
  • The entry is placed in the extensions directory with the .json file extension.

@w-e-w
Copy link
Collaborator

w-e-w commented Oct 23, 2024

I reviewed extension and found it to actually not be working on A1111

so I decided to make a fix PR

for details read the PR

you can provide your own implementation of the fixes or use my PR after that this can be merge to the index

@MINENEMA
Copy link
Contributor Author

Oh wow thanks for the detailed breakdown,

initially made it only looking at how the PNG info tab sending image params to other tabs worked and yeah i was stumped on the gradio cache issue so i just used the first working solution i came across

i assumed it worked for automatic1111 cause of its similar implementation of the parameter_copypaste.register_paste_params_button it was using

Ill merge your fix and add some minor changes
Thanks!

@w-e-w
Copy link
Collaborator

w-e-w commented Oct 23, 2024

Ability to only paste certain parameters (ex: prompt only)

I forgot to mention
Settings > Infotext > Disregard fields from pasted infotext

basically web UI has a built-in function to discard specific variables if you wish

the only issue that it's "global" at least if you're using the built-in function for parsing and passing the arguments

if you don't mind that it's Global then you can just use that but if you want specific control for your
but if you want to only discard different keys when you're pasting through your extension then you would have to be creative or maybe Implement your own functions
it might be possible to patch it so that you can detect that you are extension is activating the pasting
and when doing so apply a different set of discards

@w-e-w
Copy link
Collaborator

w-e-w commented Oct 23, 2024

the reason why it didn't work was because they gr.SelectData that you were using to get the path of the image does not
in the the version fo gradio of a1111

@w-e-w w-e-w merged commit 8275712 into AUTOMATIC1111:extensions Oct 24, 2024
1 check passed
github-actions bot pushed a commit that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants