a1111-intelli-prompt extensions

[quanghuyn94]

Info

A relatively powerful keyword suggestion system.
My repository

Checklist:

• I have read the Readme.md
• The description is written in English.
• The index.json and extension_template.json have not been modified.
• The entry is placed in the extensions directory with the .json file extension.

[w-e-w]

first issue fix install

• fix install quanghuyn94/a1111-intelli-prompt#1

[w-e-w]

I don't think your description is very helpful

You're not good at English, or you don't know how to prompt correctly. Intelli prompt will help you.

reading your description I'm unable to know what it tries to achieve

for reference

stable-diffusion-webui-extensions/extensions/a1111-sd-webui-tagcomplete.json

Lines 2 to 4 in d620c02

	"name": "Booru tag autocompletion",
	"url": "https://github.com/DominikDoom/a1111-sd-webui-tagcomplete.git",
	"description": "Displays autocompletion hints for tags from image booru boards such as Danbooru. Uses local tag CSV files and includes a config for customization.",

please modify your description to something more useful

[w-e-w]

I have to question why you've added a stand alone Intellitor Setting tab
why not just put your stuff in Settings tab like everyone else

[quanghuyn94]

Thank you, I will fix it. It seems that my sense of humor is not very appropriate. As for separating the settings, it is my laziness, sorry for this laziness. Also, I have not thought of how to do it. Thanks for your reminder, I will try my best.

[w-e-w]

major issues your color it Choice doesn't work with Default light themes

and doesn't play well with non default themes in general

[quanghuyn94]

Hum hum, I see. How to do this?

[quanghuyn94]

I hope you won't be angry with me for meeting such a person.

[quanghuyn94]

Oh, I know the reason, I was too subjective.

[quanghuyn94]

It's true that if I didn't have a professional to test it myself, it would be a mess.

[w-e-w]

just I assume that you know about https://github.com/DominikDoom/a1111-sd-webui-tagcomplete
you're basically trying to implement a different version of tagcomplete

there are lots of things that they already done right you can probably reference them for lots of things

for example they also have a json in there setting
https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/blob/1c6bba2a3d0a8d2dec0c180873e5090dee654ada/scripts/tag_autocomplete_helper.py#L645-L646

---

Hum hum, I see. How to do this?

? how did you choose the colors

I hope you won't be angry with me for meeting such a person.

why would I be angry
you're extension does work you're not spamming
most extension has bugs, and bugs are not crime

Oh, I know the reason, I was too subjective.

it is hard to understand what you're trying to say

[quanghuyn94]

Haha, thanks, I'll continue. Oh, if you ask me why I speak confusingly because I really don't know English and I speak to you using google translate.

[w-e-w]

a couple of other issues

• ctrl + space it's not a good choice for a hotkey
  I don't know if you're using Windows and what language you're using but to my knowledge on windows ctrl + space is commonly used to toggle the input language
  for example for Japanese and Chinese when you press ctrl + space it toggles between english and said language

• you should probably put some documentation about this is not compatible with
  eventhat the nature of your extension and a1111-sd-webui-tagcomplete is basically the same it is unlikely that anyone want to use these two extension together
  but if someone wishes to try your extension with the other extension installed unexpected behavior can happen

[quanghuyn94]

Ok, I have now fixed the issues you suggested, please review and help me see if there are any other issues.

[w-e-w]

Ok, I have now fixed the issues you suggested, please review and help me see if there are any other issues.

are you not seeing this?

• fix install quanghuyn94/a1111-intelli-prompt#1

also anything plus spaces probably a bad choice

• quanghuyn94/a1111-intelli-prompt@ae42717#r145112607

[quanghuyn94]

I see, I'm thinking about it.

[w-e-w]

another PR

• hires prompt quanghuyn94/a1111-intelli-prompt#2

---

the color doesn't seem to be fixed
it seems to be working with light mode now but now dark mode is the issue
text selected/hover highlight is not visible in dark mode and sometimes the background is transparent

[w-e-w]

current issues

• color
• possible key conflicts

not sure if it's more but don't think I can spend more time on this

---

your extension is working in general so if you want to release it on the index now, I can merge your PR
or you can continue to work on the issues I mentioned above it's on you
just tell me when you want to have it merge

---

personally my recommendation is "fix as many issues as possible"
reason being that there is already a very well popular and well-known extension in this category, and in a sense you are competing with them, if you wish to convert existing users from the other extention, then extension needs to have no issues that the other extension doesn't have otherwise I'm guessing they will just switch back

[quanghuyn94]

I think we should fix the problem first. It takes a lot of time.

• The key issue, I have allowed users to choose any key they want inside the config.

• The color, I'm not sure if it's good.

I think you shouldn't merge this PR, I'm not really ready yet. I need to learn more. ＞︿＜

[quanghuyn94]

[w-e-w]

keep up with the good work
I mentioned you extension and AUTO's Discord and one other Dev seems quite excited about your extension

---

I'm setting this PR as a draft for now
change the status or you can just leave a message me when you think you're ready