-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added SD Lora Tagger to extensions #285
base: extensions
Are you sure you want to change the base?
Added SD Lora Tagger to extensions #285
Conversation
sorry I am on vacation so I'm a bit solw on doing extension reviews I did a quick test a found that your extension is built for webui 1.7 and is compatible with the current master version 1.8
other minor issue personal opinion |
another issue because the namespace shared by the base webui and all other extentions and the you should avoid commn names for python scripts I my opinion the current best pretices is to put lib scripts under a diffrent dir so you don't have to worrarbout name collisions but this is for larger more complex projects |
so this is kind of awkward so yeah... basically what you're extension provide is now or will be a built-in feature (webui dev branch) this is just a heads up so that you can make your decision on whether or not to continue development |
saw ther was a 1.8 fix commit but it still doens't seem t be fixed Traceback (most recent call last):
File "B:\GitHub\stable-diffusion-webui\venv\lib\site-packages\gradio\routes.py", line 488, in run_predict
output = await app.get_blocks().process_api(
File "B:\GitHub\stable-diffusion-webui\venv\lib\site-packages\gradio\blocks.py", line 1431, in process_api
result = await self.call_function(
File "B:\GitHub\stable-diffusion-webui\venv\lib\site-packages\gradio\blocks.py", line 1103, in call_function
prediction = await anyio.to_thread.run_sync(
File "B:\GitHub\stable-diffusion-webui\venv\lib\site-packages\anyio\to_thread.py", line 33, in run_sync
return await get_asynclib().run_sync_in_worker_thread(
File "B:\GitHub\stable-diffusion-webui\venv\lib\site-packages\anyio\_backends\_asyncio.py", line 877, in run_sync_in_worker_thread
return await future
File "B:\GitHub\stable-diffusion-webui\venv\lib\site-packages\anyio\_backends\_asyncio.py", line 807, in run
result = context.run(func, *args)
File "B:\GitHub\stable-diffusion-webui\venv\lib\site-packages\gradio\utils.py", line 707, in wrapper
response = f(*args, **kwargs)
File "B:\GitHub\stable-diffusion-webui\modules\ui_extra_networks.py", line 703, in pages_html
create_html()
File "B:\GitHub\stable-diffusion-webui\modules\ui_extra_networks.py", line 699, in create_html
ui.pages_contents = [pg.create_html(ui.tabname) for pg in ui.stored_extra_pages]
File "B:\GitHub\stable-diffusion-webui\modules\ui_extra_networks.py", line 699, in <listcomp>
ui.pages_contents = [pg.create_html(ui.tabname) for pg in ui.stored_extra_pages]
File "B:\GitHub\stable-diffusion-webui\modules\ui_extra_networks.py", line 547, in create_html
"tree_html": self.create_tree_view_html(tabname),
File "B:\GitHub\stable-diffusion-webui\modules\ui_extra_networks.py", line 472, in create_tree_view_html
item_html = self.create_tree_dir_item_html(tabname, k, _build_tree(v))
File "B:\GitHub\stable-diffusion-webui\modules\ui_extra_networks.py", line 465, in _build_tree
_dir_li.append(self.create_tree_dir_item_html(tabname, k, _build_tree(v)))
File "B:\GitHub\stable-diffusion-webui\modules\ui_extra_networks.py", line 463, in _build_tree
_file_li.append(self.create_tree_file_item_html(tabname, k, v.item))
File "B:\GitHub\stable-diffusion-webui\modules\ui_extra_networks.py", line 409, in create_tree_file_item_html
"data_hash": item["shorthash"],
KeyError: 'shorthash'
Traceback (most recent call last):
File "B:\GitHub\stable-diffusion-webui\venv\lib\site-packages\gradio\routes.py", line 488, in run_predict
output = await app.get_blocks().process_api(
File "B:\GitHub\stable-diffusion-webui\venv\lib\site-packages\gradio\blocks.py", line 1431, in process_api
result = await self.call_function(
File "B:\GitHub\stable-diffusion-webui\venv\lib\site-packages\gradio\blocks.py", line 1103, in call_function
prediction = await anyio.to_thread.run_sync(
File "B:\GitHub\stable-diffusion-webui\venv\lib\site-packages\anyio\to_thread.py", line 33, in run_sync
return await get_asynclib().run_sync_in_worker_thread(
File "B:\GitHub\stable-diffusion-webui\venv\lib\site-packages\anyio\_backends\_asyncio.py", line 877, in run_sync_in_worker_thread
return await future
File "B:\GitHub\stable-diffusion-webui\venv\lib\site-packages\anyio\_backends\_asyncio.py", line 807, in run
result = context.run(func, *args)
File "B:\GitHub\stable-diffusion-webui\venv\lib\site-packages\gradio\utils.py", line 707, in wrapper
response = f(*args, **kwargs)
File "B:\GitHub\stable-diffusion-webui\modules\ui_extra_networks.py", line 703, in pages_html
create_html()
File "B:\GitHub\stable-diffusion-webui\modules\ui_extra_networks.py", line 699, in create_html
ui.pages_contents = [pg.create_html(ui.tabname) for pg in ui.stored_extra_pages]
File "B:\GitHub\stable-diffusion-webui\modules\ui_extra_networks.py", line 699, in <listcomp>
ui.pages_contents = [pg.create_html(ui.tabname) for pg in ui.stored_extra_pages]
File "B:\GitHub\stable-diffusion-webui\modules\ui_extra_networks.py", line 547, in create_html
"tree_html": self.create_tree_view_html(tabname),
File "B:\GitHub\stable-diffusion-webui\modules\ui_extra_networks.py", line 472, in create_tree_view_html
item_html = self.create_tree_dir_item_html(tabname, k, _build_tree(v))
File "B:\GitHub\stable-diffusion-webui\modules\ui_extra_networks.py", line 465, in _build_tree
_dir_li.append(self.create_tree_dir_item_html(tabname, k, _build_tree(v)))
File "B:\GitHub\stable-diffusion-webui\modules\ui_extra_networks.py", line 463, in _build_tree
_file_li.append(self.create_tree_file_item_html(tabname, k, v.item))
File "B:\GitHub\stable-diffusion-webui\modules\ui_extra_networks.py", line 409, in create_tree_file_item_html
"data_hash": item["shorthash"],
KeyError: 'shorthash' tested with corbin-hayden13/SD-Lora-Tagger@0055952 on webui version: v1.8.0 set this PR as draft for now, please leave a message when it's fixed |
Info
Repo URL here.
This extension is being actively maintained and developed.
I wasn't sure whether or not to tag the extension with "online" because there's a feature to make api requests to Civitai but this is triggered by a button click and not part of the main function of the extension, but I tagged it anyways with "online" to be safe.
Thanks for your consideration!
Checklist:
Readme.md
index.json
andextension_template.json
have not been modified.entry
is placed in theextensions
directory with the.json
file extension.