Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sd-webui-creaprompt #275

Merged
merged 1 commit into from
Feb 9, 2024
Merged

sd-webui-creaprompt #275

merged 1 commit into from
Feb 9, 2024

Conversation

tritant
Copy link
Contributor

@tritant tritant commented Feb 8, 2024

Info

Checklist:

  • I have read the Readme.md
  • The description is written in English.
  • The index.json and extension_template.json have not been modified.
  • The entry is placed in the extensions directory with the .json file extension.

@w-e-w
Copy link
Collaborator

w-e-w commented Feb 8, 2024

your extension works but you need to be careful about GradioDeprecationWarning

creaprompt.py:67: GradioDeprecationWarning: The `style` method is deprecated. Please set these arguments in the constructor instead.
  Prefix = gr.Textbox(label="Prefix of the Prompt", elem_id="promptgen_prompt_prefix", show_label=True, lines=2, placeholder="Type your prefix or leave blank if you don't want it").style(container=True)

also your extension seems to provide in duplicate functionality to the existing ones such as wildcards with integration tagcomplete extension? or other prompt symptoms extensions such as dynamic prompt
is there any reason why one would use your extension over the existing ones that have integration with other extensions?

@tritant
Copy link
Contributor Author

tritant commented Feb 8, 2024

I think yes, there are several reasons, there is much more flexibility to choose, what will be included in the result and above all we can easily include our own categories and the order in which they will appear in the result.
You can add your category easily. Just add a .csv file in the csv folder. The script will automatically add it to the interface. Each entry must be on a different line in the .csv file. Do not use special characters, no commas, only - are accepted. The file name must have a specific format, e.g. x_xnameoffile.csv. The x are numbers which will determine the display order in the prompt (alphabetical order).

@w-e-w
Copy link
Collaborator

w-e-w commented Feb 8, 2024

so I took your CSVs and rename them to txt add them to wildcard dir of wildcards and use tagcomplete to call them

image

wildcards

  • flexibility to choose, what will be included in the result
  • can easily include our own categories
  • and the order in which they will appear in the result
  • You can add your category easily

from what I can see this is the same function of you as your extensions


maybe I'm missing something obvious
if you're sure that this is useful then I will add it into index

if you continue to develop I suggest you stop calling your categories CSVs because there are not, CSV is Comma-separated_values you're using New Line separated values, which is
exactly the same format used by wildcards they're just using txt extension
you might as well make it compatible with wildcards ext and call you categories wildcards instead as it is already a turn that is being used around

@tritant
Copy link
Contributor Author

tritant commented Feb 8, 2024

Thanks for your suggestions, I'll look into it. I updated the script to remove the gradio warnings.
I think it's very interesting for beginners who don't have inspiration or don't know how to make a prompt. Starting from scratch, with just one click you can have a complete prompt that will look good.

@tritant
Copy link
Contributor Author

tritant commented Feb 9, 2024

Hello, do you intend to do the merge or not ? Because otherwise I will broadcast the github url.

@w-e-w
Copy link
Collaborator

w-e-w commented Feb 9, 2024

oh I was waiting on you to fix the gradio warning
I thought you were going to message me when you finished

ahhh you wrote "updated" not will update

@w-e-w w-e-w merged commit 1bc7a49 into AUTOMATIC1111:extensions Feb 9, 2024
1 check passed
github-actions bot pushed a commit that referenced this pull request Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants