Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sd-webui-workspace #201

Closed

Conversation

Scholar01
Copy link
Contributor

@Scholar01 Scholar01 commented Oct 4, 2023

Info

Designed to save and restore Webui workspace. It can quickly save your current webui interface and restore it the next time you use it.

Checklist:

  • I have read the Readme.md
  • The description is written in English.
  • The index.json and extension_template.json have not been modified.
  • The entry is placed in the extensions directory with the .json file extension.

@w-e-w
Copy link
Collaborator

w-e-w commented Oct 4, 2023

typo workscace -> workspace
https://github.com/Scholar01/sd-webui-workspace/blob/master/workspace/workspace.py#L46C94-L47

also I would advise not to save workspace.json under webui root
this at the very least is an annoyance and can cause issues in future
save it under your extension directory instead, and add it to your .gitignore
a fix PR for the above
Scholar01/sd-webui-workspace#1

other issues
from a quick test but I believe if you have some extension that has a gallery component such as controlnet it that allows you to input an image
if you try to save the workspace with a image loaded in controlnet, this the breakes the extension, see img and error log
considering the large amount of users that uses controlnet do you want to add an extension this state?
if you do I will add the extension to the list

2023-10-04.17_45_14_800.chrome.mp4

image
image

Traceback (most recent call last):
  File "B:\GitHub\stable-diffusion-webui\venv\lib\site-packages\gradio\routes.py", line 488, in run_predict
    output = await app.get_blocks().process_api(
  File "B:\GitHub\stable-diffusion-webui\venv\lib\site-packages\gradio\blocks.py", line 1434, in process_api
    data = self.postprocess_data(fn_index, result["prediction"], state)
  File "B:\GitHub\stable-diffusion-webui\venv\lib\site-packages\gradio\blocks.py", line 1326, in postprocess_data
    prediction_value = postprocess_update_dict(
  File "B:\GitHub\stable-diffusion-webui\venv\lib\site-packages\gradio\blocks.py", line 460, in postprocess_update_dict
    prediction_value["value"] = block.postprocess(prediction_value["value"])
  File "B:\GitHub\stable-diffusion-webui\venv\lib\site-packages\gradio\components\image.py", line 314, in postprocess
    return processing_utils.encode_array_to_base64(y)
  File "B:\GitHub\stable-diffusion-webui\venv\lib\site-packages\gradio\processing_utils.py", line 104, in encode_array_to_base64
    pil_image = Image.fromarray(_convert(image_array, np.uint8, force_copy=False))
  File "B:\GitHub\stable-diffusion-webui\venv\lib\site-packages\gradio\processing_utils.py", line 416, in _convert
    raise ValueError("Images of type float must be between -1 and 1.")
ValueError: Images of type float must be between -1 and 1.

webui version: v1.6.0-209-g7d60076
controlnet v1.1.410

@Scholar01
Copy link
Contributor Author

Firstly, my gratitude for your rectification. I have just amended an error concerning the importation when the Image type is numpy. Presently, it operates seamlessly. However, a minor imperfection lingers: should a file be imported while the Accordion is closed, it necessitates a click on the image refresh button to display. I shall ponder a resolution to mend this shortly.

@Scholar01
Copy link
Contributor Author

I may require some testing, as numerous errors persist; I shall initiate a merge request subsequently. Once again, thank you!

@Scholar01 Scholar01 closed this Oct 4, 2023
@w-e-w
Copy link
Collaborator

w-e-w commented Oct 4, 2023

cool


btw when addind the the index, don't add the added date

"added": "2023-10-04"

this will be filled automatically by the GitHub action using the time of merge

@w-e-w w-e-w mentioned this pull request Dec 15, 2023
4 tasks
@w-e-w
Copy link
Collaborator

w-e-w commented Dec 15, 2023

any progress on your extension?


just to let you know someone is working on a similar extension
#248


and in case there was a communication error before
also it's okay to put the extension on the index in its current state (assuming that the situation hasn't changed)
I was only pointing out a bug that might affect users who uses controlnet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants