Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes towards v1.1 #267

Merged
merged 68 commits into from
Jun 18, 2024
Merged

Fixes towards v1.1 #267

merged 68 commits into from
Jun 18, 2024

Conversation

RafaelPalomar
Copy link
Collaborator

No description provided.

gatangen and others added 30 commits September 1, 2023 08:04
@gatangen
BUG: Fix correct handling of Attribute.
9a21b6f
@gatangen
Merge remote-tracking branch 'origin/develop' into bug/multiple_vascu…
229f582 
…lar_territories_#249
@olevs @RafaelPalomar
BUG: Fix Windows compile and link errors
c01526c
@gatangen
BUG: Fix faulty merging of centerline segments.
e7831c7
@gatangen
Debug printouts
f5765f4
@gatangen
Merge remote-tracking branch 'origin/develop' into Handling_segmentat…
85e44df 
…ion_UI
@gatangen
WIP: Setting attributes for vessel points list and centerline models.
25b1b3c
@gatangen
BUG: Fixed filtering of Vessel Points list based on Attributes.
10fb7a0
@gatangen
BUG: Fixed faulty clearing of "Vascular Territory Segmentation" combo…
14d2dd7 
…box list when calculating vascular territory segmentation.
@gatangen
ENH: Editorial changes.
aca9231
@gatangen
ENH: Editorial changes.
de0a30d
@gatangen
WIP: Debug printouts.
0a32c0f
@gatangen
WIP: Visualization of centerline segments corresponding to current Va…
7d4b940 
…scular Territory Segmentation Id.
@gatangen
WIP: Fixed initialisation of Vascular Territory Segmentation node.
3b236f3
@gatangen
BUG: qMRMLNodeComboBox do not filter on both specified attributes, on…
592ffea 
…ly on the last specified. Setting this to be Vascular Territory Segmentation.
@gatangen
WIP: Hide previous Vascular Territory Segmentation when selecting a new.
b880e46
@gatangen
BUG: Fixed faulty building of complete centerline model before segmen…
5d0b81c 
…tation of vascular territories.
@gatangen
BUG: Fixed failing unit test.
d208d90
@gatangen
BUG: Should not make a "Vessel Points" list for Vascular Territory Se…
71c087b 
…gmentation nodes.
@gatangen
BUG: Fixed faulty updating of color-table.
f3d6a48
@gatangen
BUG: Updating segmentation node when changing Vascular Territory Segm…
c074678 
…entation in GUI.
@gatangen
ENH: Deactivate Place mode for Markup points when switching between V…
9989889 
…ascular Territory and Vascular Territory Segmentation.
@gatangen
ENH: Removing debug printouts.
98660b2
@gatangen
ENH: Updating documentation.
3265c08
@gatangen
ENH: Updating documentation.
2aba0ec
@gatangen
BUG: Fixed faulty updating of Vessel Points list.
68c99fd
@gatangen
BUG: Fixed widget updates after reloading scene.
3e9cb5b
@olevs
WIP: Try to add c++ test to LiverSegments logic. Not working yet
3eca8d1
@gatangen
ENH: Removed debug comment.
8b0560d
@olevs
WIP: Fixed compile issue
3393d5f
olevs and others added 29 commits February 29, 2024 10:52
@olevs
WIP: Fix use of C++ calculateVascularTerritoryMap, and started moving…
db63da0 
… a VMTK function: polyDataFromNode
@olevs
WIP: Merged in fixes from bug/multiple_vascular_territories_#249
994dd3b
@olevs
WIP: Fixed faling test
2bbf79a
@olevs
WIP: Removed commented Python code replaced by C++ code
47377d0
@olevs
WIP: Make sure all functions in LiverSegmentsLogic are tested
7d5927a
@olevs
ENH: Converted function code from Python to C++: preprocessAndDecimate
82a0337
@olevs @RafaelPalomar
DOC: Added JOSS example paper and bib file templates. #260
2808508
@olevs @RafaelPalomar
DOC: Added JOSS example text in paper.md. #260
57f97cc
@gatangen @RafaelPalomar
DOC: Add paper content
ff8f528
@RafaelPalomar
DOC: Move pape to own folder
6f799f5 
This moves the paper files to its own folder and modifies the github
workflow files to adjust for this
@RafaelPalomar @olevs
@gatangen @dalbenzioG @RuoyanMeng
DOC: Update paper conten
dd8de0d 
Co-authored-by: Ole Vegard Solberg <[email protected]>
Co-authored-by: Geir Arne Tangen <[email protected]>
Co-authored-by: Gabriella d'Albenzio <[email protected]>
Co-authored-by: Ruoyan Meng <[email protected]>
@olevs @RafaelPalomar
COMP: Fix paper pdf generation workflow
6e10435
@dalbenzioG @RafaelPalomar
DOC: Add atypical vs. anatomical figure to paper
6fba3d9
@RafaelPalomar
DOC: Fix typos in paper
8b04b10
@RafaelPalomar
DOC: Fix figures
64d9abd
@olevs @RafaelPalomar
DOC: Minor changes and typo fixes
bbbe7ec
@dalbenzioG @RafaelPalomar
Add GdA ORCID
3c58a40
@dalbenzioG @RafaelPalomar
Add Couinaud segments figure
a624f81
@dalbenzioG @RafaelPalomar
Add bib reference
3d72d56
@dalbenzioG @RafaelPalomar
Paper revision GdA
934e3ac
@dalbenzioG @RafaelPalomar
Fix typo in the text
b787ed6
@dalbenzioG @RafaelPalomar
Remove { width=100% } under resectogram figure
63ffc9b
@dalbenzioG @RafaelPalomar
Revert "Remove { width=100% } under resectogram figure"
7d8aad9 
This reverts commit 3985a4e.
@olevs @RafaelPalomar
DOC: Fixed ref to fig 4
e2e7309
@gatangen @RafaelPalomar
DOC: Minor additions to text.
4e98f87
@olevs @RafaelPalomar
DOC: Minor text changes
06aeb75
@RafaelPalomar
Merge pull request #263 from SINTEFMedtek/feature/LiverSegmentsRewrite
79ce9ee 
Feature/liver segments rewrite
@RafaelPalomar
ENH: Update upload artifacts workflow
f27fc31
@RafaelPalomar
Merge pull request #268 from ALive-research/RafaelPalomar-patch-1
8065aa7 
ENH: Update upload artifacts workflow
@RafaelPalomar RafaelPalomar merged commit a767755 into master Jun 18, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RafaelPalomar @gatangen @olevs @dalbenzioG