Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let backend set network mode #4445

Open
6543 opened this issue Nov 23, 2024 · 5 comments
Open

Let backend set network mode #4445

6543 opened this issue Nov 23, 2024 · 5 comments
Labels
feedback this needs feedback refactor delete or replace old code

Comments

@6543
Copy link
Member

6543 commented Nov 23, 2024

In my mind ... the compiler sets the network mode ... and makes asumption it does not know ...

So we have to check how networkmode is currently handled ... and refactor to move tha logic out from the frontemd

NetworkMode string `yaml:"network_mode,omitempty"`

@6543 6543 added the refactor delete or replace old code label Nov 23, 2024
@6543
Copy link
Member Author

6543 commented Nov 23, 2024

E.g. if important to change -> dedicated backend option

@qwerty287
Copy link
Contributor

This is set nowhere. If you have network privileges, you can set it in your YAML, otherwise it remains empty.

@qwerty287
Copy link
Contributor

@6543 does my comment is enough so we can close it? Or what's your intention with the issue?

@qwerty287 qwerty287 added the feedback this needs feedback label Dec 16, 2024
@6543
Copy link
Member Author

6543 commented Dec 18, 2024

NetworkMode string `yaml:"network_mode,omitempty"`

It's still undocumented feature ...

@qwerty287
Copy link
Contributor

Yes, but that's not what this issue seems to be about?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback this needs feedback refactor delete or replace old code
Projects
None yet
Development

No branches or pull requests

2 participants