Recent menu redesign issue and implementation tracker

[Stoppedpuma]

Only affected on #495, clicking any item in the left-most row does nothing but make the menu go away.

[woelper]

This is nasty and happens because it is in a submenu. I've tried lots of things (too many!) and we might have to go for a simple recent list instead of thumbnails until we figure out a better way.

[Stoppedpuma]

Sure! How about this for now? This variant is inspired by your original redesign on the old recent-images branch but adapted to fit the current designs. The format icon should follow the accent colour. Additionally, feel free to play with boldness on the format icon as well, I think semi-bold looks better but didn't include it in the picture below for the sake of simplicity.

[woelper]

This is getting pretty hard - I think this is a missing feature in egui that might have been fixed, but notan is on an older version. What happens is that a submenu opens directly over the previous menu, which looks very bad. I think newer egui versions shift the submenu to the left if there is no space left to the right.

I need to move the menu manually to the left for this reason. However, no clicks are detected within the region that I have moved the menu:

In this image, you can see the red area to the right that I have shifted the submenu by. Unfortunately this area is ignored on the left side. This is what caused the previous thumbnails to ignore clicks.

I see a couple of options:

• Check if newer egui versions do this correctly, and ask notan to upgrade or do the PR ourselves
• Design a submenu that is not shifted (draws over parent menu)
• Find out if we can shift the response so clicks are not ignored (tried this, seems hard)
• Incorporate the shift (make submenu contain items that are only as wide as the parent menu)

[woelper]

I have to settle for this now:

[Stoppedpuma]

I see, I should have figured that this was caused by horizontal space but this seem to have went past me for some reason. I'm sure you've already had several headaches dealing with this and don't want to touch it again at the moment so lets just go with this for now! For future reference though, I do have a vertical version of the thumbnail design which might have solved this. I've attached this below but don't feel the need to change anything at the moment if you are getting annoyed at this part, this seems like a pretty hard to get around limitation which should probably be addressed on egui / notans side, I'll read around documentation later just in-case and open an issue if there's nothing we're missing.

For now, I've pushed a change which restores the hamburger menu's width since this was pretty horrendous visually and restoring to the original width doesn't seem to cause any problems. I'm also going to remove the blocker tag and rename this to a tracker for future endeavours since this seems to be good enough for the next release on my part!