-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Ads in app #422
Comments
i believe closing the ad after app launch is not a big problem |
Isn't the point of this application not to have Ads? Amongst other features of course. Yes it's not a big issue if you can X out of it, but how can we help to diagnose /why/ they are there and maybe we can figure out how to block them better as there's a number of other 'closed' issues reporting the same thing. Simply closing the issue doesnt seem right. |
yeah, the main point of EeveeSpotify is to make the app think you have a premium subscription and unlock some features like shuffle, free listening, etc. it also disables ads — you can listen to tracks freely. however, some users may see an ads banner on the homepage occasionally. this banner is easily closable, and I believe it’s not something that really needs to be fixed or causes much inconvenience. you can try enabling overwrite configuration option, which may help as it replaces the remote configuration from server (containing many UI/UX parameters) with the dumped premium one however, to fully resolve this issue, i would need to investigate spotify ad logic, see exactly how the app determines to show ads, etc., which i’m not currently doing. i don’t even get these banners myself — definitely not on app launch. might see one once every few months, which I just close i think I’ll leave the issue open; maybe someday someone will open a pull request with a fix for these ads if interested. i hope you understand my point of view regarding this |
Understood - I can imagine its very difficult to troubleshoot a 'bug' that only displays every few months, or more frequently for others, and sporadically at that. For Is there anything we can do to help diagnose? I don't have any real coding experience, but if we can replicate it and see what IP it's reaching out to (maybe a specific 'ad server') that can help to block it? Personally, I run Pi-Hole at home which would log what IPs the device is reaching out to. |
eevee is right. all eeveespotify does is make spotify think you have premium (and add some features), and you can tell it works with features like unlimited skips and such. a minor banner ad that doesn't even show up for him often isn't too big of a deal, simply close the ad also duplicate of #270 |
some updates: recently i started constantly getting ads on the home page, so looked into it. turned out that spotify has very complicated ads logic, most of which is disabled if the |
I haven't gotten ads for a week but now they're back on the home screen in full force. i'm on v5.8.2 |
I've also recently (last night) had ads playing in between songs when casting to a Google Home Max. I know sometimes when casting it does a "handoff" to that device and that device streams direct from the service which could introduce ads. I'm unsure if that's the case or not. |
basically, the ad is delivered to the client via a protobuf response. the client sets up the UI for the ad ( |
yeah, the ads are delivered to the client alongside the entire home screen layout, it’s DAC (probably representing Dynamic App Component). unlike HUB components, which are used on the artist page, the home screen layout uses protobuf and more complicated logic, with almost everything written in swift, which is very difficult to hook and play with it’s UIKit, though. another option would be modifying the server response, but it seems unrealistic, since you would have to recreate all the protobuf structures, like hundreds, in order to deserialize/remove them, and it would break any time spotify decides to add a new component or change something so, the only solution so far is to simply close the ad. yeah, it’ll appear again when the layout reloads (every |
Forgive me because this is way over my head, but just curious if it is even remotely possible:
|
nope |
i have a premium account so maybe your team can fix it? |
Is this issue appropriate?
Is this issue unique to EeveeSpotify?
Have you searched the existing issues?
Describe the bug.
Is anyone else getting an advertisement on the main screen in the app now? I can easily close it by hitting the X button, but it comes back every time I open the app.
Example:
https://imgur.com/a/n96W4HO
The text was updated successfully, but these errors were encountered: