Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

movePrimaryCursorIntoVisibleRange is overzealous #2126

Open
zpencer opened this issue Dec 12, 2024 · 1 comment
Open

movePrimaryCursorIntoVisibleRange is overzealous #2126

zpencer opened this issue Dec 12, 2024 · 1 comment

Comments

@zpencer
Copy link
Contributor

zpencer commented Dec 12, 2024

Sorry looks like my proposed fix for #2009 is causing unforeseen problems. Now the cursor is moved to the top / bottom of the screen in scenarios where it doesn't make sense. For example, jump to definition should put the cursor on the symbol, but instead we now see the cursor placed at the top/bottom edge of the screen.

@whitphx
Copy link
Owner

whitphx commented Dec 17, 2024

Thank you, but

jump to definition should put the cursor on the symbol, but instead we now see the cursor placed at the top/bottom edge of the screen.

I couldn't reproduce this issue in my env.
Could you provide sample code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants