Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A way to configure the number in flight requests for tiles #4157

Open
varun7654 opened this issue Sep 28, 2024 · 3 comments
Open

A way to configure the number in flight requests for tiles #4157

varun7654 opened this issue Sep 28, 2024 · 3 comments
Labels
Feature Request Requests for Features

Comments

@varun7654
Copy link

Feature Description:

if (this._loadingTiles.length > 4) {

I'd like a way to easily configure the 4 to a higher value.

Additional context:

As far as I can tell, increasing this value allows more requests to be in flight when loading tiles. On my server increasing this to 100 has resulted in much more responsive tile loading. This should disproportionality benefit users with higher ping as they'll no longer have to wait for all adjacent tiles to be loaded before requesting more.

You can already adjust this by editing the respective file on your actual server; I'd just like an easier way to do this for others. You can also test this by editing the js in the browser itself :)

@varun7654 varun7654 added the Feature Request Requests for Features label Sep 28, 2024
@faresbouzayen
Copy link

Hey @varun7654! Great suggestion! Increasing the number of in-flight requests for tiles can definitely enhance the user experience, especially for those with higher ping times.

Here are a couple of ideas to implement this feature more smoothly:

Configuration File: It might be useful to have a dedicated configuration file where server administrators can easily adjust the in-flight request limit without digging into the source code. This could help make it more user-friendly!

UI Option: If possible, adding an option in the server admin interface to adjust this value dynamically could provide even more flexibility for users.

Documentation Update: It would also be helpful to update the documentation to highlight this feature once implemented, so users know how to adjust it for optimal performance.

Thanks for bringing this up! Looking forward to seeing how this can improve tile loading for everyone! 😊

@rautamiekka
Copy link
Contributor

Higher ping often also means the modem/router can't handle a whole many simultaneous requests/connections, much less many requests in a quick succession, assuming the service even is good enough to.

@varun7654
Copy link
Author

I don't think that's really a fair assumption to make unless you're running your instance in the same one you're accessing it from.

On my instance tiles take about ~200 ms to load which would limit it to loading only about 20 tiles a second which feels extremely sluggish.

Changing this value on my server has improved the performance dramatically and really is a night and day difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Requests for Features
Projects
None yet
Development

No branches or pull requests

3 participants