Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

Upgrade DiffusionBee dependancies to compile ES2020 #10

Open
joshJarr opened this issue Nov 8, 2022 · 0 comments
Open

Upgrade DiffusionBee dependancies to compile ES2020 #10

joshJarr opened this issue Nov 8, 2022 · 0 comments
Assignees

Comments

@joshJarr
Copy link

joshJarr commented Nov 8, 2022

see: divamgupta#299


When working with the electron app we noticed ES2020 was not being compiled correctly. Features such as optional chaining were throwing compilation errors as the loader for these files were outdated. This was also the case for files imported from node_modules meaning any library that used this modern JS syntax would not compile.

To fix this we updated the vue-cli-plugins and noticed that babel-eslint is deprecated, so updated this to use @babel/eslint-parser.

This had a side effect of also upgrading webpack to version 5+.
Webpack 5+ no longer polyfills node.js modules, this caused a few errors across the frontend so we added node-polyfill-webpack-plugin to ensure these necessary modules were available in the frontend.

A side effect of bumping the babel and vue-cli versions were that automated linting occurred when building and serving the electron app blocking compilation. To get around this we added a temporary .eslintignore file to discard these complaints for now.

TLDR: This PR updates the vue-cli and babel/eslint dependancies so that they are able to compile JS files and modules that use modern ES2020 syntax, aligning with the vue (.vue) file loader.

@joshJarr joshJarr self-assigned this Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant