Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In CI, check for TS errors in built server code (of example app) by running npx tsc #2384

Open
infomiho opened this issue Nov 25, 2024 · 1 comment
Open

In CI, check for TS errors in built server code (of example app) by running npx tsc #2384

infomiho opened this issue Nov 25, 2024 · 1 comment
Labels
ci Continuous integration

Comments

@infomiho
Copy link
Contributor

We want to make sure that there not TS errors in the built server app (e.g. our TODO app example) by running npx tsc.

Right now, we have some TS errors that we didn't really handle and we should make sure that our CI is passing once we introduce this check.
@infomiho infomiho added the ci Continuous integration label Nov 25, 2024
@infomiho infomiho mentioned this issue Nov 25, 2024
Merged
4 tasks
@Martinsos Martinsos changed the title Run npx tsc on the built server code Check for TS errors in built server code by runnning npx tsc Nov 27, 2024
@Martinsos Martinsos added enhancement New feature or request and removed enhancement New feature or request labels Nov 27, 2024
@Martinsos Martinsos changed the title Check for TS errors in built server code by runnning npx tsc In CI, check for TS errors in built server code (of example app) by running npx tsc Nov 27, 2024
@Martinsos
Copy link
Member

https://github.com/wasp-lang/wasp/blob/main/waspc/examples/todoApp/ensure_app_compiles_and_builds.sh

client, server .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci Continuous integration
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Martinsos @infomiho