-
-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue]: Networks incorrect initial sort order on load #3541
Comments
initial sort is "almost perfect" - reason is that each lora needs to be analyzed for metadata when its getting registered as available and that is triggered in separate thread so it doesn't block overall server startup. most of the threads complete before server is ready and sort is applied, but depending on the system, some may take a bit longer - so such loras would not be sorted during initial sort. only solution would be to basically "pause" server startup until everything is ready and that can take significant time, depending on number of models/loras/embeddings/etc - i don't think we should do that. any subsequent sort is correct since all items are already registered. |
I agree that it shouldn't wait. Could another solution be to make the refresh button apply the current sort since all loras should be analyzed at that point? |
yes, that should be doable, just need to figure out how to reproduce so i can test and its really timing dependent. i'll probably need to create fake lora that loads very slowly. |
ok, this should now be resolved. make sure you're using latest dev branch AND clear browser cache. |
Issue Description
Default sort order is set to [A-Z], but there is some strangeness on first load. All loras are in subfolders.
Here you can see some of the lora sorted by a-z, but some are missing.
The rest are later down the list, it appears to group the loras into two groups and sort each one a-z
After cycling through all the 6 sort methods back to [A-Z] it's sorted correctly
Version Platform Description
No response
Relevant log output
No response
Backend
Diffusers
UI
Standard
Branch
Master
Model
StableDiffusion XL
Acknowledgements
The text was updated successfully, but these errors were encountered: