Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue]: Networks incorrect initial sort order on load #3541

Closed
2 tasks done
futaposting opened this issue Oct 31, 2024 · 4 comments
Closed
2 tasks done

[Issue]: Networks incorrect initial sort order on load #3541

futaposting opened this issue Oct 31, 2024 · 4 comments
Labels
wontfix This will not be worked on

Comments

@futaposting
Copy link

Issue Description

Default sort order is set to [A-Z], but there is some strangeness on first load. All loras are in subfolders.
Here you can see some of the lora sorted by a-z, but some are missing.
Capture
The rest are later down the list, it appears to group the loras into two groups and sort each one a-z
Capture3
After cycling through all the 6 sort methods back to [A-Z] it's sorted correctly
Capture2

Version Platform Description

No response

Relevant log output

No response

Backend

Diffusers

UI

Standard

Branch

Master

Model

StableDiffusion XL

Acknowledgements

  • I have read the above and searched for existing issues
  • I confirm that this is classified correctly and its not an extension issue
@vladmandic vladmandic changed the title [Issue]: Sort order on load incorrect [Issue]: Networks incorrect initial sort order on load Oct 31, 2024
@vladmandic vladmandic added the bug Something isn't working label Oct 31, 2024
@vladmandic vladmandic added the backlog Valid issue but requires non-trivial work and is placed in backlog label Dec 24, 2024
@vladmandic
Copy link
Owner

initial sort is "almost perfect" - reason is that each lora needs to be analyzed for metadata when its getting registered as available and that is triggered in separate thread so it doesn't block overall server startup. most of the threads complete before server is ready and sort is applied, but depending on the system, some may take a bit longer - so such loras would not be sorted during initial sort.

only solution would be to basically "pause" server startup until everything is ready and that can take significant time, depending on number of models/loras/embeddings/etc - i don't think we should do that.

any subsequent sort is correct since all items are already registered.

@vladmandic vladmandic added wontfix This will not be worked on and removed bug Something isn't working backlog Valid issue but requires non-trivial work and is placed in backlog labels Dec 28, 2024
@futaposting
Copy link
Author

I agree that it shouldn't wait. Could another solution be to make the refresh button apply the current sort since all loras should be analyzed at that point?

@vladmandic
Copy link
Owner

yes, that should be doable, just need to figure out how to reproduce so i can test and its really timing dependent. i'll probably need to create fake lora that loads very slowly.

@vladmandic
Copy link
Owner

ok, this should now be resolved. make sure you're using latest dev branch AND clear browser cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants