Replace "require" is not always needed

[zorn-v]

Describe the bug

Some packages (as uniqid) make checks like if(typeof require !== 'undefined') to ensure that we are in node env.
But vite replace that require to _require which is defined and then "module as been externalized"...

I think if it is not function call, there is no need to transform that check.

Reproduction

https://stackblitz.com/edit/vitejs-vite-dpwfwp?file=main.js
adamhalasz/uniqid#48

Steps to reproduce

npm create vite vite-project -- --template vanilla
cd vite-project
npm i
npm i uniqid
echo "import uniqid from 'uniqid'" >> main.js
npm run dev

Then open http://localhost:5173/ in browser and check browser console

System Info

System:
    OS: Linux 5.19 Ubuntu 22.10 22.10 (Kinetic Kudu)
    CPU: (4) x64 Intel(R) Core(TM) i3-7100 CPU @ 3.90GHz
    Memory: 10.53 GB / 15.57 GB
    Container: Yes
    Shell: 5.2.2 - /bin/bash
  Binaries:
    Node: 16.18.0 - /usr/local/bin/node
    npm: 8.19.2 - /usr/local/bin/npm
  Browsers:
    Chromium: 107.0.5304.87
    Firefox: 106.0.5
  npmPackages:
    @vitejs/plugin-vue: ^3.2.0 => 3.2.0 
    vite: ^3.2.2 => 3.2.2

Used Package Manager

npm

Logs

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[github-actions]

Hello @zorn-v. Please provide a minimal reproduction using a GitHub repository or StackBlitz. Issues marked with need reproduction will be closed if they have no activity within 3 days.

[zorn-v]

Added steps to reproduce

[suguanYang]

evanw/esbuild#1966 (comment)

[sapphi-red]

Yeah, this is how esbuild treats require.

It's better to use conditional exports instead of runtime check.