Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic custom config should saved in ConfigMap #354

Open
veezhang opened this issue Oct 18, 2023 · 0 comments
Open

dynamic custom config should saved in ConfigMap #354

veezhang opened this issue Oct 18, 2023 · 0 comments
Labels
find-by-e2e Bugs that find by e2e. type/enhancement Type: make the code neat or more efficient

Comments

@veezhang
Copy link
Contributor

Introduction

Currently, only static custom configurations are stored in ConfigMap. Dynamic custom configurations are set through the flags api and need to be set every time Reconcile, including Pods restart.

flags := staticFlags(cfg)
klog.V(3).Infof("cluster [%s/%s] sync %s configmap with custom static configs %v", namespace, clusterName,
component.ComponentType().String(), flags)
customConf := config.AppendCustomConfig(template, flags)

I think dynamic custom configuration should also be stored in ConfigMap. It only needs to be set once when it changed, and it will automatically take effect after restarting.

Contents

Related work

@veezhang veezhang added type/enhancement Type: make the code neat or more efficient find-by-e2e Bugs that find by e2e. labels Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
find-by-e2e Bugs that find by e2e. type/enhancement Type: make the code neat or more efficient
Projects
None yet
Development

No branches or pull requests

1 participant