Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of the hanning function does not match its description #122

Open
jschepers opened this issue Nov 11, 2024 · 2 comments
Open

Implementation of the hanning function does not match its description #122

jschepers opened this issue Nov 11, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@jschepers
Copy link
Collaborator

At the moment, the hanning function is implemented in such a way that the peak of the hanning window will not be at the user-given peak.
What needs to be changed is this line: return pad_array(signal, -Int(round(offset * sfreq / 2)), 0)
The shifting (zero-padding) also needs to be dependent on the given duration (apart from the offset).
@jschepers jschepers added the bug Something isn't working label Nov 11, 2024
@behinger
Copy link
Member

I can fix this if you want

@behinger
Copy link
Member

#128 it's fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@behinger @jschepers