Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty line in dataframe #345

Open
tkoskela opened this issue Sep 23, 2024 · 4 comments
Open

Empty line in dataframe #345

tkoskela opened this issue Sep 23, 2024 · 4 comments
Assignees
Labels
bug Something isn't working postprocessing

Comments

@tkoskela
Copy link
Member

My LEXCI benchmarks produce an odd empty line in my data frame

image

The raw perflog only has 8 lines with %tasks=1 so I'm not sure where this is coming from. I also get it in the csv export. Not a blocker since I filter it away anyways, but maybe worth having a look at.

@tkoskela tkoskela added bug Something isn't working postprocessing labels Sep 23, 2024
@pineapple-cat
Copy link
Collaborator

Hmm... Is there any more information you can provide to help us replicate this issue? Assuming you're not transforming the data in some way, maybe this is caused by a newer version of something or other?

I just tried to process your preflog on the current version of the main branch and both my dataframe and csv export look fine. Here's what I get after adding num_tasks, median_value, and median_unit to extra columns and sorting the dataframe by num_tasks:
image

@tkoskela
Copy link
Member Author

I've got
Streamlit, version 1.38.0
Python 3.12.3
pandas Version: 2.2.2

This config definitely reproduces it on my side

{
"title":"Test"
"x_axis":{
"value":"num_tasks"
"units":{
"custom":NULL
}
"sort":"ascending"
}
"y_axis":{
"value":"median_value"
"units":{
"column":"mean_unit"
}
"scaling":{
"custom":NULL
}
}
"filters":{
"and":[]
"or":[]
}
"series":[]
"column_types":{
"num_tasks":"int"
"median_value":"float"
"mean_unit":"str"
}
"extra_columns_to_csv":[]
}

@pineapple-cat
Copy link
Collaborator

It must be version sorcery then; the config above doesn't reproduce your empty dataframe line for me with Streamlit v1.30.0, Python v3.8.10, and pandas v1.5.3 (though no graph is generated due to a row / unique x-axis value mismatch). We'll have to look for the culprit later.

@ilectra
Copy link
Collaborator

ilectra commented Dec 4, 2024

I get some different wacky behaviour with Streamlit 1.38.0, which disappears with version 1.30.0 : when I import a config in the GUI, the config on the right is correctly updated, but the axis options on the left are not, therefore the plotting fails. This is weird, because the rest of the fields (filters and series) are correctly filled, and the dataframe columns corresponding to the axis are there.
I will fix the Streamlit version for now, but we need to keep this in mind....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working postprocessing
Projects
None yet
Development

No branches or pull requests

3 participants