Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scaling in Streamlit post-processing #330

Open
pineapple-cat opened this issue Jun 7, 2024 · 0 comments
Open

Fix scaling in Streamlit post-processing #330

pineapple-cat opened this issue Jun 7, 2024 · 0 comments

Comments

@pineapple-cat
Copy link
Collaborator

ln 323 in streamlit_post_processing.py was recently changed "x_value": y_scaling_x"x_value": str(y_scaling_x) to fix a config export issue, however this broke scaling functionality in the web app.

We could try to fix this by typing the scaling x-value before performing comparisons with it, such as:

  • changing ln 264 in post_processing.py scaling_x_value_mask = (self.df[x_column] == scaling_column.get("x_value"))scaling_x_value_mask = (self.df[x_column] == self.val_as_col_dtype(scaling_column["x_value"], x_column).iloc[0])
  • under ln 251 in streamlit_post_processing.py adding and using typed_x_val = state.post.val_as_col_dtype(axis["scaling"]["column"]["x_value"], state.x_axis_column).iloc[0]

However, these fixes alone are not enough because we must find a way to get around the error thrown if the app tries to type a "None" string as numeric (specifically, I found this was an issue when typing to Int64).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant