Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot find module 'node:os' #1404

Closed
alukach opened this issue Mar 5, 2022 · 3 comments · Fixed by #1406
Closed

Cannot find module 'node:os' #1404

alukach opened this issue Mar 5, 2022 · 3 comments · Fixed by #1406
Assignees
@JoshuaKGoldberg
Labels
good first issue Good for newcomers; welcome aboard! status: accepting prs Please, send in a PR to resolve this! ✨ type: bug Something isn't working

Comments

@alukach
Copy link

alukach commented Mar 5, 2022

🐛 Bug Report

  • tslint-to-eslint-config version: 2.12.2
  • ESLint version: 8.10.0
  • Node version: 14.17.3

Actual Behavior

➤ npx tslint-to-eslint-config
npx: installed 64 in 3.749s
Cannot find module 'node:os'
Require stack:
- /Users/alukach/.npm/_npx/251/lib/node_modules/tslint-to-eslint-config/src/cli/runCli.js
- /Users/alukach/.npm/_npx/251/lib/node_modules/tslint-to-eslint-config/src/cli/main.js
- /Users/alukach/.npm/_npx/251/lib/node_modules/tslint-to-eslint-config/bin/tslint-to-eslint-config

Expected Behavior

Conversion to work.

Reproduction

I'm assuming this is due to #1365
@alukach
Copy link
Author

alukach commented Mar 5, 2022

Running the following unblocked me:

npx [email protected]

@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented Mar 5, 2022 •
edited
Loading

Ah, TIL that node:os isn't supported in Node <16. Thanks for this @alukach! I'll release a patch version shortly that fixes this import.

@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Mar 5, 2022
@JoshuaKGoldberg JoshuaKGoldberg added good first issue Good for newcomers; welcome aboard! status: accepting prs Please, send in a PR to resolve this! ✨ type: bug Something isn't working labels Mar 5, 2022
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Mar 5, 2022
Merged
2 tasks
@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented Mar 5, 2022 •
edited
Loading

The fix should be released in [email protected] 👍 . Please let me know if not!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
good first issue Good for newcomers; welcome aboard! status: accepting prs Please, send in a PR to resolve this! ✨ type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove node: imports typescript-eslint/tslint-to-eslint-config
2 participants
@alukach @JoshuaKGoldberg