Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure on using dataStoreSecrets #566

Open
jasonxu-129 opened this issue Dec 5, 2024 · 2 comments
Open

Failure on using dataStoreSecrets #566

jasonxu-129 opened this issue Dec 5, 2024 · 2 comments

Comments

@jasonxu-129
Copy link

Hello, I'm trying to deploy Trino Gateway using Helm (version 1.13.0). I have populated the dataStoreSecrets section and removed the dataStore configuration from the config section. However, the final configuration still includes the default values, override/merge from dataStoreSecrets doesn't show up.

dataStore:
   driver: org.postgresql.Driver
   jdbcUrl: jdbc:postgresql://localhost:5432/gateway
   password: mysecretpassword
   user: postgres

I see code in templates/secrets.yaml

data:
    config.yaml: "{{toYaml (merge .Values.config $authenticationDict $dataStoreDict $backendStateDict ) | b64enc}}"

I'm not sure how these default values are being populated. Could someone help me understand? Thank you in advance!

@jasonxu-129
Copy link
Author

jasonxu-129 commented Dec 6, 2024

@willmostly helped investigate in slack channel, he find it's due to in
merge .Values.config $authenticationDict $dataStoreDict $backendStateDict
.Values.config is populated with the custom values you supply + the default values... which contains

dataStore:
   driver: org.postgresql.Driver
   jdbcUrl: jdbc:postgresql://localhost:5432/gateway
   password: mysecretpassword
   user: postgres

the merge function does give precedence to the leftmost dictionary, the default will prevent the value from the secret from taking effect.

@jasonxu-129
Copy link
Author

I'm using the workaround Will suggested now

config:
  dataStore: null

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant