Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XRP: new addresses are not generated in Receive page even after successfull transaction #16139

Open
gavlig opened this issue Jan 2, 2025 · 2 comments
Labels
bug Something isn't working as expected

Comments

@gavlig
Copy link

gavlig commented Jan 2, 2025

Describe the bug
With selected XRP account when going to Receive and clicking Show Full Address only one first initial address is given even after successful previous transactions. Tried this for DOGE and the issue doesn't get reproduced there. This is especially a problem with shady banks that block addresses 'for review' and never unblock them making crypto transfer to wallet almost impossible without creating a new account for every next transaction.

Info:

  • Remembered Wallet: no
  • Suite Version: Trezor-Suite-24.12.3-linux-x86_64.AppImage + 24.12.3 on mac + web + latest git from 01.01.2025 on linux (adb2ff4)
  • Browser: chrome 131.0.6778.205
  • Browser Installation Method: downloaded installer
  • OS: archlinux, macOS Monterey
  • Bridge:
  • Firmware Version: Trezor Safe 3, 2.8.8 / dd4671a5104952ef505d28d1f9e94d1484b4607a

How to reproduce
Steps to reproduce the behavior:

  1. Select an XRP account
  2. Go to 'Receive' on the top right
  3. Click on 'Show Full Address'
  4. See that new address doesn't get generated, only the same one gets repeatedly shown

Expected behavior
A new address gets generated every time a 'Show Full Address' is clicked as described in this documentation: https://trezor.io/learn/a/use-new-address-for-each-transaction

Screenshots
N/A

Additional context
I'm happy to help with debugging this, i have made a local setup from latest sources, it's building, but i'm not very experienced with TypeScript so i'm currently stuck with trying to make function showAddress show me some of my logs. I've tried making new Logger as well as obtaining it from global, but after introducing this to showAddress the button stops working as in no new window appears after clicking on it, so i'm suspecting i'm missing something here.
This is how i've been creating it:

const logger = new Logger('debug', {
        colors: true, // Turning off colors
        logFormat: '%dt %lvl: %msg', // Level and message only
        writeToDisk: false, // Write to disk
        outputFile: 'log-temp.txt', // Static file name, will be overwritten if it exists
        writeToConsole: true,
});

getting it via global also doesnt work:

const { logger } = global;

Any help would be greatly appreciated, cheers!

@gavlig gavlig added the bug Something isn't working as expected label Jan 2, 2025
@github-project-automation github-project-automation bot moved this to 🎯 To do in Issues Suite Jan 2, 2025
@gavlig
Copy link
Author

gavlig commented Jan 2, 2025

it starts looking like this is an xrp limitation, i didnt find official documentation about it, but there is this thread on reddit: https://www.reddit.com/r/TREZOR/comments/1hortoj/cannot_generate_new_receive_address/
If this is the case, maybe it's worth adding this info somewhere, maybe here https://trezor.io/learn/a/xrp-on-trezor-safe-5-trezor-safe-3-and-trezor-model-t

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected
Projects
Status: 🎯 To do
Development

No branches or pull requests

2 participants
@gavlig and others