Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete move to Typescript #34

Open
2 tasks
nirga opened this issue Feb 26, 2023 · 3 comments
Open
2 tasks

Complete move to Typescript #34

nirga opened this issue Feb 26, 2023 · 3 comments

Comments

@nirga
Copy link
Member

nirga commented Feb 26, 2023

Our project started as a Javascript project and is gradually moving to Typescript.

  • Complete update of all .js files to .ts.
  • Fix all outstanding ESLint issues.
@arimus
Copy link

arimus commented Nov 14, 2023

Just a note that issue #81 which I closed is related to this issue.

@nirga
Copy link
Member Author

nirga commented Nov 14, 2023

Thanks @arimus! Are you willing to submit your code as a PR?

@arimus
Copy link

arimus commented Nov 16, 2023

I submitted a PR to share my code, but I have not extensively tested. I had trouble testing / setting up this project even after the successful import, but the commit shows how I was able to get a build that moves more to TS and properly works in a commonjs targeted application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants