-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Radio inputs - using Arrow keys to navigate focuses incorrect inputs #1048
Comments
Thanks for the report ❤️ |
@ph-fritsche, @kentcdodds could we get this issue resolved? Also #1198 is a duplicate. There are 3 very similar PRs opened to get it fixed, could one be picked and merged? |
I'm afraid I have no bandwidth to work on this project :( |
That is fair, I tagged you only because I saw you both as committers in the last ten commits to main. Do you know if there is anyone else apart from you and Philipp who could have the time to take a look? |
I'm thinking maintenance of this library has kind of fallen off I'm afraid. If you're blocked I recommend just using fireEvent directly or jumping into a more wholistic solution with playwright. |
Sad to hear it, particularly as tools like Storybook depend on it but thanks for sharing the suggestions |
Perhaps someone from storybook would be interested in taking maintenance! 🙏 |
Reproduction example
https://codesandbox.io/s/ancient-forest-44xrzm?file=/src/App.js
Prerequisites
Render a group of at least 3 radio inputs that:
name
attributedisabled
)Expected behavior
Codesandbox test: https://codesandbox.io/s/ancient-forest-44xrzm?file=/src/App.test.js
Keyboard user events should follow the patterns outlined here.
Specifically,
ArrowRight
andArrowDown
should advance the focus within the radio group, wrapping back to the beginning if needed.ArrowLeft
andArrowUp
should reverse the focus within the group, wrapping back to the end if needed.Actual behavior
Arrow keys send focus to the wrong input in the Radio Group. E.g.,
ArrowRight
send focus through all the inputs to the last input in the group.User-event version
14.4.3
Environment
Bug is reproducible in CodeSandbox, so skipping this section.
Testing Library framework:
JS framework:
Test environment:
DOM implementation:
Additional context
Radio group arrow functionality was added here - #995
The text was updated successfully, but these errors were encountered: