-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split the helm chart into a new repo or Equate the the Helm chart version with the pod-reaper version #80
Comments
I actually don't know much about helm... I see a couple of things like this:
Seems like both of those are candidates for matching up with the pod-reaper version correct? |
Trying to ask this a different way. With charts also being versioned, are the charts published anywhere (or are they someone pulled directly from github/here)? Trying to see if/when these have been published. I've got a lot to learn here! |
Nice, so regarding that, the strategy that is most common to opensource projects is to create a separate repo only for the helm files, create the helm package and add it to the repo as well and then integrate that repo with the CNCF project https://artifacthub.io/. I can see those steps ahead.
Let me know if I can help somehow. |
Hey, I took the liberty to execute the steps above, but I would only use it if you agree, and then I would transfer the ownership to you. |
Only managed to find a bit of time to dig at this... What's the advantage of having a separate repository for just the chart? Doesn't that mean keeping both in sync? |
So that is a nice question and my points are pretty much related to your comment when you mention the "just have full kubernetes manifest files live in my application's repository, fully codifying the app, deployment configuration, and pipeline together in the same repo". :)
Cons:
|
Ping! |
I'm currently leaning towards trying to do it in this repo, but mostly because it means fewer PRs, makes it easier to automate between release of the helm chart and the code. Also because I'm not an owner/admin of the Target organization, so I'd have to have someone else make it (unless I want to do it under my personal space). |
Yep, fair enough, I still did not understand the fewer PR's that you mentioned since the Helm charts are not really being changed that much. |
Oh, maybe my understanding is wrong... wouldn't I want to update the helm chart to use the latest version of the pod-reaper in the helm chart each time I update the pod-reaper? I'm mostly thinking about this version number:
|
No it is not that one.
|
Ping... |
Thanks for the ping. I'm mostly just swamped with work this week. I promise it's still on my to-do list Is there a date you'd really like to see this by? Or just as ASAP thing? In either case, honestly appreciate the reminders! |
haha, for me it would be an ASAP thing, haha. |
@rogerioefonseca When this is all working properly, what are some examples of commands you want to see working? |
@slushpupie Do you (or know someone else) know/use helm well/often? Struggling with a back and forth between wanting to keep everything together and breaking it out/letting someone else (even if it's me) own the helm chart. |
Sure! We can do pair programming and discuss the pros and cons. https://calendly.com/d/cmr-zbp-64k/helm-chart-conversation Regarding your points:
2 - And yes I use Helm often |
got a Sincere apologies, but I've been swamped the last few weeks and I'm still catching up. Still poking at this when I catch a few minutes here and there. |
Hey there, sorry for the lack of reply! |
Hello, I'm configuring the pod-reaper helm chart with Renovate bot, then I figured that the helm chart version is not the same as the pod-reaper code.
For that there are 2 strategies that I can see now:
1 - Separate the Helm chart code in a new repo and maintain it there (That would be a better OMHO)
2 - Equate the Helm Chart version to match the pod-reaper version so then I could create a new MR with a real tagging version.
The text was updated successfully, but these errors were encountered: