Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AutoDiff] Fix adjoints for loop-local active values #78374

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[AutoDiff] Fix adjoints for loop-local active values #78374

wants to merge 1 commit into from
+558 −37

Conversation

kovdan01
Copy link
Contributor

Fixes #78264

@kovdan01
Copy link
Contributor Author

Tagging @asl @JaapWijnen @rxwei

@kovdan01 kovdan01 marked this pull request as ready for review December 27, 2024 21:35
@kovdan01 kovdan01 requested a review from eeckstein as a code owner December 27, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eeckstein eeckstein Awaiting requested review from eeckstein eeckstein is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adjoint for active values in loops are just wrong
1 participant
@kovdan01