-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build fail on Windows #15
Comments
This is a regression due to the 72.1 upgrade. I've filed swiftlang/swift#70029 to track enabling CI for Windows. I don't see how to fix this. The changes have hardcoded a dependency on oslog. It is unclear to me how this builds on Linux. |
Thanks. I think @iCharlesHu was looking into similar failures on Linux |
This was obscuring the current foundation blocker for Windows: ICU. The last update to ICU broke the Windows build and there does not seem to be a clear repair for that. See swiftlang/swift-foundation-icu#15 for more details on the ICU failure. In the meantime, repair the `environ` handling for Windows. `unistd.h` is the Unix standard header which must be available when `__unix__` is defined. Add an explicit check for that to avoid including the header on other platforms.
This was obscuring the current foundation blocker for Windows: ICU. The last update to ICU broke the Windows build and there does not seem to be a clear repair for that. See swiftlang/swift-foundation-icu#15 for more details on the ICU failure. In the meantime, repair the `environ` handling for Windows. `unistd.h` is the Unix standard header which must be available when `__unix__` is defined. Add an explicit check for that to avoid including the header on other platforms.
@parkera, @iCharlesHu, @itingliu - any chance of getting a release with the changes to allow a bump in apple/swift-foundation? That should help get the Windows CI on track. |
@compnerd we tagged swift-foundation has also been updated. |
I try to use swift-foundtion in my package on Windows, and it give me these errors:
My envrioments:
OS: Windows 10 19045.3208
Windows sdk: Windows 10.0.19041.0/10.0.20348.0
Complier: MSVC v143 vs2022
VSCode version: 1.80.1
CodeLLDB version: v1.9.2
Compiler: swift-clang
Debuggee: x86_64-windows-msvc
compnerd.org Swift version: 5.8.1 (swift-5.8.1-RELEASE)
The text was updated successfully, but these errors were encountered: