Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DontRepeatTypeInStaticProperties message doesn't match what it detect #854

Open
thomasvl opened this issue Oct 14, 2024 · 2 comments
Open

Comments

@thomasvl
Copy link

  1. Checkout https://github.com/apple/swift-protobuf @ c9fbc332ed293c64ff70af8d82367ca530dce11c

  2. swift format lint Sources/SwiftProtobuf/Message.swift - Will produce a warning:

    Sources/SwiftProtobuf/Message.swift:46:16: warning: [DontRepeatTypeInStaticProperties] remove the suffix 'Message' from the name of the variable 'protoMessageName'

The error message says to remove the suffix 'Message', but the variable isn't a suffixed with 'Message'. The check must be doing an contains on the name. Not sure if the impl or the error message is wrong.

@ahoppen
Copy link
Member

ahoppen commented Oct 14, 2024

Synced to Apple’s issue tracker as rdar://137894442

@MahdiBM
Copy link

MahdiBM commented Dec 8, 2024

Just bumped into this:

Sources/PostgresNIO/Data/PostgresData+Bytes.swift:26:23: warning: [DontRepeatTypeInStaticProperties] remove the suffix 'Data' from the name of the variable 'postgresDataType'

postgresDataType simply does not have a suffix of Data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants