Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.6 themes explicit color definition #4721

Open
yn1046 opened this issue Dec 15, 2024 · 1 comment
Open

3.6 themes explicit color definition #4721

yn1046 opened this issue Dec 15, 2024 · 1 comment

Comments

@yn1046
Copy link

yn1046 commented Dec 15, 2024

What I did

Tried to redo the famous Dracula theme via the new Themes feature from 3.6 preview:

Themes [
	[
		Name = Dracula
		TextColor = #F8F8F2
		BackgroundColor = #282A36
		ControlBackgroundColor = #282A36
		LinkColor = #FF79C6
		ColorizeControls = true
	]
]

What I got

Because the text color (#F8F8F2) is a shade (an extremely white one) of yellow, some text colors are implicitly defined as varieties of yellow (e.g. disabled button text, disabled button selection, text links).

image

Proposal

Remove this confusing implicit color logic. The user should be able to define ALL the colors used in the UI explicitly in the Themes section of settings.

@GitHubRulesOK
Copy link
Collaborator

Hmm that themes site relies on suggesting non conventual settings so

Default Light is

Themes [
]

Default Dark is

Themes [
]

Theme = Dark from 3.5 is

Themes [
]

So the simplest is delete any custom "Themes" entries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants