Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi values for the RDMA resource injection annotation of the spidermultusconfig #4358

Open
cyclinder opened this issue Dec 3, 2024 · 3 comments · May be fixed by #4421
Open

Multi values for the RDMA resource injection annotation of the spidermultusconfig #4358

cyclinder opened this issue Dec 3, 2024 · 3 comments · May be fixed by #4421
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature

Comments

@cyclinder
Copy link
Collaborator

cyclinder commented Dec 3, 2024

What would you like to be added?

Add support for cni.spidernet.io/rdma-resource-inject multiple values, which are separated by commas. This can be used for different purposes with the same spidermultusconfig representation.

目前 cni.spidernet.io/rdma-resource-inject 这个 annotation 用于表示创建 AI 应用时自动注入 RDMA 网络资源,参考文档:https://github.com/spidernet-io/spiderpool/blob/main/docs/usage/install/ai/get-started-macvlan-zh_CN.md#%E5%9F%BA%E4%BA%8E-webhook-%E8%87%AA%E5%8A%A8%E6%B3%A8%E5%85%A5-rdma-%E7%BD%91%E7%BB%9C%E8%B5%84%E6%BA%90。目前该注解打在 spidermultusconfig 上 时只有一个 value,只能表示同一组的 spidermultusconfig 配置。客户可能有特殊需求,比如不同的 AI 应用可能希望 4 网卡或 8 网卡,所以需要给同一个 spidermutlsuconfig 赋予多个意义。

希望能够支持该注解的多 value, 类似: cni.spidernet.io/rdma-resource-inject: nic4,nic8

apiVersion: spiderpool.spidernet.io/v2beta1
kind: SpiderMultusConfig
metadata:
  name: gpu1-sriov
  namespace: spiderpool
  annotations:
    cni.spidernet.io/rdma-resource-inject: nic4,nic8
spec:
  cniType: macvlan
  macvlan:
    master: ["enp11s0f0np0"]
    enableRdma: true
    rdmaResourceName: spidernet.io/gpu1rdma
  ippools:
    ipv4: ["gpu1-net11"]

4 网卡 AI pod1:

spec:
  template:
    metadata:
      annotations:
        cni.spidernet.io/rdma-resource-inject: nic4

8 网卡 AI pod2:

spec:
  template:
    metadata:
      annotations:
        cni.spidernet.io/rdma-resource-inject: nic8

Why is this needed?

No response

How to implement it (if possible)?

No response

Additional context

No response

@cyclinder cyclinder self-assigned this Dec 3, 2024
@cyclinder cyclinder added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Dec 9, 2024
@cyclinder
Copy link
Collaborator Author

可以参考 #4258 实现

补充: 新加一个 annotation: cni.spidernet.io/network-resource-inject, 在实现 cni.spidernet.io/rdma-resource-inject 的能力基础上,实现 underlay 网络资源的注入

@cyclinder
Copy link
Collaborator Author

@yanhb-nil

@yanhb-nil
Copy link

copy it

@cyclinder cyclinder assigned yanhb-nil and unassigned cyclinder Dec 9, 2024
@yanhb-nil yanhb-nil linked a pull request Dec 19, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants