Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: change remark-lint:no-dead-urls to warn instead of error #89

Open
transitive-bullshit opened this issue Jul 31, 2019 · 4 comments
Open

Proposal: change remark-lint:no-dead-urls to warn instead of error #89

transitive-bullshit opened this issue Jul 31, 2019 · 4 comments
Labels
enhancement help wanted

Comments

@transitive-bullshit
Copy link
Collaborator

transitive-bullshit commented Jul 31, 2019 •
edited
Loading

This seems to be tripping a lot of people up and there are a decent number of edge cases that will be difficult to resolve robustly in all cases (e.g., rate limits, IP blacklists when running from CI, temporary server outages, etc).

See transitive-bullshit/check-links#4 for the main issue where many authors have included their false negatives. Also see #88, #85, #50, and numerous other issues raised that are referenced in transitive-bullshit/check-links#4.

My proposal would be to make these warnings instead of hard errors.
@transitive-bullshit transitive-bullshit changed the title Consider making unreachable URLs a warning instead of error Consider making remark-lint:no-dead-urls a warning instead of error Jul 31, 2019
@transitive-bullshit transitive-bullshit changed the title Consider making remark-lint:no-dead-urls a warning instead of error Proposal: change remark-lint:no-dead-urls to warn instead of error Jul 31, 2019
This was referenced Jul 31, 2019
Closed
Closed
Closed
@sindresorhus
Copy link
Owner

Sure

@caufieldjh caufieldjh mentioned this issue Sep 30, 2019
Merged
@jessevdp jessevdp mentioned this issue Oct 4, 2019
Closed
3 tasks
@jessicalostinspace jessicalostinspace mentioned this issue Mar 30, 2020
Merged
@jthegedus jthegedus mentioned this issue Apr 7, 2020
Merged
5 tasks
@chinesedfan
Copy link
Contributor

The rule has been removed in https://github.com/sindresorhus/awesome-lint/releases/tag/v0.13.0, so this issue can be closed now.

@fregante

This comment was marked as outdated.

Sign in to view
@andy5995
Copy link

The rule has been removed in https://github.com/sindresorhus/awesome-lint/releases/tag/v0.13.0, so this issue can be closed now.

readme needs updating https://github.com/sindresorhus/awesome-lint#special-comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@sindresorhus @transitive-bullshit @fregante @chinesedfan @andy5995