Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unsupport macos sdk 11.3 #28244

Closed
zebozhuang opened this issue Mar 6, 2021 · 5 comments · Fixed by #28650
Closed

unsupport macos sdk 11.3 #28244

zebozhuang opened this issue Mar 6, 2021 · 5 comments · Fixed by #28650

Comments

@zebozhuang
Copy link

I try to build it on my Macos with the following error, it seems it does not support macos sdk 11.3, but I can not downgrade to 11.0.

DEBUG: yasm: Trying yasm
INFO: /usr/local/bin/yasm
INFO: checking yasm version...
DEBUG: Executing: /usr/local/bin/yasm --version
INFO: 1.3.0
DEBUG: Executing: xcrun --show-sdk-path
ERROR: SDK version "11.3" is unsupported. Please downgrade to version 11.0. You may need to point to it using --with-macos-sdk= in your mozconfig.

--- stderr
ERROR: SDK version "11.3" is unsupported. Please downgrade to version 11.0. You may need to point to it using --with-macos-sdk= in your mozconfig.
make: *** [maybe-configure] Error 1

@jdm
Copy link
Member

jdm commented Mar 6, 2021

You can work around this by cloning https://github.com/servo/mozjs/ and modifying https://github.com/servo/mozjs/blob/d0f33e89cf3881a8032dba6a109b4e42f1f1b690/mozjs/build/moz.configure/toolchain.configure#L155 to read 11.3, then patching mozjs_sys to use the local clone.

@adamcypher
Copy link

adamcypher commented Jun 21, 2021

There's another work-around described here:
https://firefox-source-docs.mozilla.org/setup/macos_build.html#macos-sdk-is-unsupported

My question is, where should the mozconfig file be placed to specify the SDK path?
And setting the MOZCONFIG environment var to the location of the mozconfig does not work (?!)

@jdm
Copy link
Member

jdm commented Jun 22, 2021

The supported workaround for servo is setting the MACOS_SDK_PATH environment variable to point to a supported SDK: https://github.com/servo/mozjs/blob/ef986b1a2c23081fe4d37aeaab5323d3dec033f3/makefile.cargo#L14 . A supported one can be acquired from https://github.com/phracker/MacOSX-SDKs.

@PhotonQuantum
Copy link

PhotonQuantum commented Nov 10, 2021

I also encountered this issue when building servo today, and was guided to https://firefox-source-docs.mozilla.org/setup/macos_build.html#macos-sdk-is-unsupported incorrectly.

  --- stderr
  ERROR: SDK version "12.0" is unsupported. Please downgrade to version 11.1. See the manual SDK installation docs: https://firefox-source-docs.mozilla.org/setup/macos_build.html#macos-sdk-is-unsupported
  make: *** [maybe-configure] Error 1
  thread 'main' panicked at 'assertion failed: result.success()', /Users/lightquantum/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/de147f0/build.rs:172:5

Is there any plan to update the build error message to avoid misunderstanding?

@jdm
Copy link
Member

jdm commented Nov 10, 2021

I've filed servo/mozjs#289 about that idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants