Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Origin port as an Option<u16> #821

Open
MidasLamb opened this issue Mar 2, 2023 · 0 comments · May be fixed by #989
Open

Origin port as an Option<u16> #821

MidasLamb opened this issue Mar 2, 2023 · 0 comments · May be fixed by #989

Comments

@MidasLamb
Copy link

According to https://html.spec.whatwg.org/multipage/browsers.html#concept-origin, the port part of a tuple origin can be null, so it seems that Origin::Tuple(String, Host<String>, u16) should be Origin::Tuple(String, Host<String>, Option<u16>)
@mrobinson mrobinson mentioned this issue Oct 31, 2024
Merged
3 tasks
mrobinson added a commit that referenced this issue Oct 31, 2024
@mrobinson
Make the port of Origin be an Option<u16>
1538bf4 
The URL specification changed in 2016 [1] [2] such that now the origin's port
should be the same as the URL's port. This means that the port can
`None` in the case that it is the default port for a scheme.

1. whatwg/url@b0e4def
2. whatwg/html#870

Fixes #821.
@mrobinson mrobinson linked a pull request Oct 31, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make the port of Origin be an Option<u16> servo/rust-url
1 participant
@MidasLamb