Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CapturedJSStack::as_string should pass a principal argument #534

Open
jdm opened this issue Dec 14, 2024 · 0 comments
Open

CapturedJSStack::as_string should pass a principal argument #534

jdm opened this issue Dec 14, 2024 · 0 comments

Comments

@jdm
Copy link
Member

jdm commented Dec 14, 2024

We always pass a null pointer to BuildStackString right now:

ptr::null_mut(),

Equivalent code in Firefox obtains the current context realm and the realm of the stack object and chooses the least privileged of the two (by checking if one subsumes the other). Another option would be to allow the caller to pass an explicit principal and delegate this choice to the embedder, which would (naively) require making this an unsafe method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant