Added GC Tracing Infrastructure #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved Traceable Trait to mozjs_sys Crate Reorganised GC Code
Implemented Traceable Trait for RootableVec Reformatted Imports Moved GC Re-exports
|
After doing some testing on spiderfire, particularly with this code, it seems that this rooting works properly. I haven't tested |
Implemented Traceable for Integers, Floats and Atomic Integers Implemented Traceable with Macro for Tuples up to Length 12 Implemented Traceable with Macro for Function Pointers with up to 12 arguments
|
@jdm Could I get a review on this? |
jdm
approved these changes
Jun 20, 2023
|
This looks good to merge! |
|
@bors-servo r+ |
|
📌 Commit c216686 has been approved by |
|
☀️ Test successful - checks-github |
This was referenced Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #346
Moved
mozjs::rust::Tracetomozjs::gc::trace::Traceable, and added more implementations for smart pointers, wrappers, and collections.Added
mozjs::gc::trace::RootedTraceableSet,mozjs::gc::collections::RootableVecandmozjs::gc::collections::RootedVec.Added
rooted_vec!macro.Reorganised GC-related code in
mozjs.I'm not too sure about the file structure change, but I think it's fine.
If there's any more high-level rooted structures I can add, please do inform me.