Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No obvious contribution guidelines #453

Open
pmj opened this issue Mar 26, 2021 · 1 comment
Open

No obvious contribution guidelines #453

pmj opened this issue Mar 26, 2021 · 1 comment

Comments

@pmj
Copy link
Contributor

pmj commented Mar 26, 2021

First of all, thanks for maintaining these low-level macOS framework bindings and wrappers. I wouldn't have been able to start using Rust for some small work projects (which I'm hoping to use as a springboard for bigger things) if I'd had to put in the extra work of creating my own bindings.

I came across a minor omission in the core-graphics crate, which I've rectified locally and put into a pull request (#452) - but I've not found any notes in the readme, GitHub wiki, or elsewhere about what exactly the protocol is for submitting contributions. Even if it's just a one-line "If you wish to start contributing or even make a one-off change, simply submit a pull request with the code or documentation change and we'll go from there," then that would be helpful for people who find themselves in the position I found myself in just now.

@jrmuizel
Copy link
Collaborator

This crate is a bit under maintained so we don't really have anything like that. That being said, I'd say your one-line contribution guideline is a good place to start and would accept a PR adding it :)

bors-servo added a commit that referenced this issue Nov 29, 2021
Add basic contfibution guidelines to README

In #453, @pmj proposed bare-bones contribution guidelines, which were received favorably by @jrmuizel. This pull request insert's @pmj's proposed text into the top-level README.
bors-servo added a commit that referenced this issue Mar 27, 2022
Add basic contfibution guidelines to README

In #453, @pmj proposed bare-bones contribution guidelines, which were received favorably by @jrmuizel. This pull request insert's @pmj's proposed text into the top-level README.
bors-servo added a commit that referenced this issue Mar 27, 2022
Add basic contfibution guidelines to README

In #453, @pmj proposed bare-bones contribution guidelines, which were received favorably by @jrmuizel. This pull request insert's @pmj's proposed text into the top-level README.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants