Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add performance.measure for SSR hydration in dev mode #4932

Open
pmdartus opened this issue Nov 25, 2024 · 2 comments
Open

Add performance.measure for SSR hydration in dev mode #4932

pmdartus opened this issue Nov 25, 2024 · 2 comments
Labels
developer productivity issues marked as such are intended to help developers to not trip down enhancement hydration Having to do with hydration after SSR Up for grabs Issues that are relatively small, self-contained, and ready for implementation

Comments

@pmdartus
Copy link
Member

The LWC engine generates spans in the Chrome devtools timeline through performance.measure in dev mode. The framework offers great coverage for client-side rendered components. It would be great to have the same coverage for SSR rehydrated components.

Here is the trace of an LWR application mixing CSRed and SSR rehydrated components.

Untitled drawing (2)

@pmdartus pmdartus added developer productivity issues marked as such are intended to help developers to not trip down Up for grabs Issues that are relatively small, self-contained, and ready for implementation hydration Having to do with hydration after SSR labels Nov 25, 2024
@nolanlawson
Copy link
Collaborator

This is about hydration, but I'm wondering if this would be helpful in @lwc/ssr-runtime as well? Maybe not, since it's so fast as-is?

@nolanlawson
Copy link
Collaborator

Also this would be a good time to rename hydrate/rehydrate to something else, since those names predate us implementing actual hydration. (e.g. render/re-render).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer productivity issues marked as such are intended to help developers to not trip down enhancement hydration Having to do with hydration after SSR Up for grabs Issues that are relatively small, self-contained, and ready for implementation
Projects
None yet
Development

No branches or pull requests

2 participants