Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled buttons still can be clicked to send their events on iOS and iPadOS #320

Open
AWSW-de opened this issue Nov 18, 2024 · 0 comments

Comments

@AWSW-de
Copy link

AWSW-de commented Nov 18, 2024

Describe the bug
Disabled buttons still can be clicked to send their events when using Safari on iOS or iPadOS. This seems to be OS or browser related because latest FireFox in Windows 11 or Safari in macOS 15.1 react as expected.

According to the library documentation disabled buttons should not only look like disabled to the user, they should not ‘fire’ their events when the ‘setEnabled(ID, false)’ is set.

Optically this seems to work, but in my last try is still fires the event when I click on the disabled button when using iOS or iPadOS.

buttonUpdateNowID = ESPUI.button("Update to the new software now", &buttonUpdateNow, ControlColor::Dark, "Start software update now", (void*)1);

ESPUI.setEnabled(buttonUpdateNowID, false); 

To Reproduce
Steps to reproduce the behavior:

  1. Add a button similar like in the short code snippet above
  2. Click on the disabled button with Safari (iPadOS or iOS) and with Firefox (Windows 11) or Safari on macOS 15.1
  3. Check the reaction on the device.

Expected behavior
A disabled buttons should not forward actions when someone clicks on it when it is not enabled.

Screenshots
IMG_0422

Desktop (please complete the following information):

  • OS: Windows 11 or macOS 15.1
  • Browser FireFox / Safari
  • Version 132 / 15.1

Smartphone (please complete the following information):

  • Device: iPad Pro M4 or iPhone 15 Pro Max
  • OS: iPadOS / iOS 18.1
  • Browser: Safari
  • Version 18.1

Additional context
Add any other context about the problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant