New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variable Scope looks wrong #184

Open

karianpour opened this issue Oct 10, 2024 · 0 comments

karianpour commented Oct 10, 2024

https://github.com/romkor/svelte-portal/blob/bddbc7c6d95c84b073b05319646ee25cdec3e5a5/src/Portal.svelte#L11C9-L11C17

I guess that "targetEl" variable can be defined inside the "update" function as follow:

  export function portal(el, target = "body") {
-    let targetEl;
    async function update(newTarget) {
-      target = newTarget;
+    let targetEl;
      if (typeof target === "string") {

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment