Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux 4.11 ASPM powersupersave mode #101

Open
mlen opened this issue May 5, 2017 · 6 comments
Open

Linux 4.11 ASPM powersupersave mode #101

mlen opened this issue May 5, 2017 · 6 comments
Assignees

Comments

@mlen
Copy link

mlen commented May 5, 2017

4.11 kernel introduced new ASPM mode which should be used in pcie-aspm hook if the support for is detected. Probably it'd be nicer to allow to configure the mode to use on ac and on battery, so that users can choose the right mode for them

@rickysarraf
Copy link
Owner

Are you referring to these recent changes ?

@mlen
Copy link
Author

mlen commented May 6, 2017 via email

@mlen
Copy link
Author

mlen commented May 6, 2017

Having ASPM_BATTERY_POLICY and ASPM_AC_POLICY configuration variables would be ideal for me

@rickysarraf
Copy link
Owner

IIRC, I did explore those power saving attributes. But the improvements weren't substantial. But I'll revisit it again, soon.

Regarding BATT and AC tunables, yes, it'd be nice to have them. If you already have a patch, please do submit it here.

@mlen
Copy link
Author

mlen commented May 9, 2017

I don't have a patch yet, for now I just patched the script locally. I'll take a look at this again some time later (probably in June), because -ENOTIME

@robbertkrebbers
Copy link

Having ASPM_BATTERY_POLICY and ASPM_AC_POLICY configuration variables would be ideal for me

I second that it would be great to have these options.

With my laptop I ran into the same issue as described here: https://bugzilla.kernel.org/show_bug.cgi?id=215832#c38 That is, powersave results in battery drain in s2idle, but using powersupersave solves the problem.

Hence it would be great to tell laptop-mode-tools to use powersupersave.

With the lack of an option to set this policy is there a workaround to tell laptop-mode-tools to use powersupersave?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants