Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dead link is not really dead #12

Closed
dialex opened this issue Jan 7, 2019 · 8 comments
Closed

Dead link is not really dead #12

dialex opened this issue Jan 7, 2019 · 8 comments

Comments

@dialex
Copy link

dialex commented Jan 7, 2019

Your lib marks this link as dead https://vimeo.com/78912852 but it's not, as you can see by clicking it.

@wooorm
Copy link
Member

wooorm commented Jan 9, 2019

@dialex
Copy link
Author

dialex commented Jan 12, 2019

Nevermind, I created my own script to validate broken links.
This lib and remark-validate-links give me too much false positives (ie. marks valid links as dead). I'm sorry, this is too unreliable for me.

@dialex dialex closed this as completed Jan 12, 2019
@NewAlexandria
Copy link

NewAlexandria commented Mar 26, 2019

Can we re-open this issue? Some vimeo links still are marked dead, when they are not.

- Linting
✖ Linting
  README.md:212:3
  ✖  212:3  Link to https://vimeo.com/20241649 is dead  remark-lint:no-dead-urls
  ✖  213:3  Link to https://vimeo.com/9790850 is dead   remark-lint:no-dead-urls
  2 errors

@wooorm

@NewAlexandria
Copy link

NewAlexandria commented Mar 26, 2019

@dialex I don't see your link validation lib. Can you post / package it, please?

@davidtheclark
Copy link
Contributor

See transitive-bullshit/check-links#4. check-links is the lower-level link-checking library this plugin uses. I'm sure they'd appreciate a PR, if @dialex or anybody else has ways to fix some false positives.

@dialex
Copy link
Author

dialex commented Mar 26, 2019

@NewAlexandria My bad, it was in a branch. It's merged now, this is the file. I asked a friend, it took him a couple of hours, and it works (so far no false positives) 👍

To run it: node scripts/link-validator.js docs/**/*.md (docs is my folder with markdown files)

@fregante
Copy link

I'm having the same issue here: https://travis-ci.org/fregante/Awesome-WebExtensions/jobs/563973345#L208

It says https://bfred.it is not working (both on Travis and my computer) but the URL loads fine

@wooorm
Copy link
Member

wooorm commented Jul 26, 2019

@fregante please post an issue on the underlying project, mentioned above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

5 participants