-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dead link is not really dead #12
Comments
@dialex Could you expand on this? Here’s some more info on creating a good, actionable, issue. |
Nevermind, I created my own script to validate broken links. |
Can we re-open this issue? Some vimeo links still are marked dead, when they are not.
|
@dialex I don't see your link validation lib. Can you post / package it, please? |
See transitive-bullshit/check-links#4. check-links is the lower-level link-checking library this plugin uses. I'm sure they'd appreciate a PR, if @dialex or anybody else has ways to fix some false positives. |
@NewAlexandria My bad, it was in a branch. It's merged now, this is the file. I asked a friend, it took him a couple of hours, and it works (so far no false positives) 👍 To run it: |
I'm having the same issue here: https://travis-ci.org/fregante/Awesome-WebExtensions/jobs/563973345#L208 It says https://bfred.it is not working (both on Travis and my computer) but the URL loads fine |
@fregante please post an issue on the underlying project, mentioned above. |
Your lib marks this link as dead https://vimeo.com/78912852 but it's not, as you can see by clicking it.
The text was updated successfully, but these errors were encountered: