Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Replace the FastAI notebook by a cartesian product with PyTorch and remove the FastAI dependency #2186

Open
3 tasks
miguelgfierro opened this issue Nov 11, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@miguelgfierro
Copy link
Collaborator

miguelgfierro commented Nov 11, 2024

Description

We had some issues with the FastAI dependency #2182. And realised that the fastai notebook is just a fancy wrapper on PyTorch cartesian product between user and item embeddings.
https://github.com/recommenders-team/recommenders/blob/main/examples/00_quick_start/fastai_movielens.ipynb

Expected behavior with the suggested feature

We want replace the FastAI notebook with a PyTorch version

Willingness to contribute

  • Yes, I can contribute for this issue independently.
  • Yes, I can contribute for this issue with guidance from Recommenders community.
  • No, I cannot contribute at this time.

Other Comments

Related to #1713

@miguelgfierro miguelgfierro added the enhancement New feature or request label Nov 11, 2024
@miguelgfierro miguelgfierro changed the title [FEATURE] Replace the FastAI notebook by a dot product with PyTorch and remove the FastAI dependency [FEATURE] Replace the FastAI notebook by a cartesian product with PyTorch and remove the FastAI dependency Nov 11, 2024
@miguelgfierro
Copy link
Collaborator Author

IDEA: I'm sure ChatGPT can translate the notebook to PyTorch

@rohan-rajput-ai
Copy link

@miguelgfierro I am unclear with the requirements. Do we just want to replace the Cartesian product or we want to completely replace fast-ai with the PyTorch?

@miguelgfierro
Copy link
Collaborator Author

@rohan-rajput-ai the idea is to remove all the code related to FastAI, and replace it with the underlying PyTorch. The output of this work needs to be a remade notebook, the removal of https://github.com/recommenders-team/recommenders/blob/main/recommenders/models/fastai/fastai_utils.py and the removal of the fastai dependency https://github.com/recommenders-team/recommenders/blob/main/setup.py#L54.

If you need to create any function, feel free to create a pytorch_utils.py file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants