Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency of ReadiumCSS filters across Themes #53

Open
JayPanoz opened this issue Dec 31, 2024 · 0 comments
Open

Consistency of ReadiumCSS filters across Themes #53

JayPanoz opened this issue Dec 31, 2024 · 0 comments
Assignees

Comments

@JayPanoz
Copy link
Contributor

When using ReadiumCSS sepia mode/theme, you get the blending of images out of the box. Currently, paper and contrast3 (a.k.a. mint) don’t do that, which is inconsistent.

Since these filters are now exposed globally through the latest PR, this means you can reuse them as you see fit, although you would have to do that manually in code based on the theme’s name cause we don’t have anything to cover that in theme properties in preferences.

There are 2 ways to see this issue, which are not exclusive of each other:

  1. Should ReadiumCSS’ sepia mode/theme blend images by default? We’ve already had an instance where this was an issue.
  2. Should we extend theme props in preferences so that you can define images are blended, darkened, and/or inverted (+ gaiji)?

Notes:

  • the darken and invert filters now accepts percentages in addition to the readium-{filter}-on keyword/flag that was previously implemented so that you can try to match the color of your custom background;
  • there is the gaiji case for invert on top of that, applying to Japanese books only.

Any opinion? I know we discussed this with @HadrienGardeur yesterday and @danielweck opened the issue I referred to above so they should be interested in this issue but any feedback obviously welcome.

@JayPanoz JayPanoz self-assigned this Dec 31, 2024
@JayPanoz JayPanoz changed the title Consistency of ReadiumCSS filters through Themes Consistency of ReadiumCSS filters across Themes Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Draft
Development

No branches or pull requests

1 participant