Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning for log pattern used in PooledConnectionProvider #3561

Closed
Doc94 opened this issue Dec 23, 2024 · 4 comments · Fixed by #3571
Closed

Warning for log pattern used in PooledConnectionProvider #3561

Doc94 opened this issue Dec 23, 2024 · 4 comments · Fixed by #3571
Assignees
@violetagg
Labels
type/bug A general bug
Milestone
1.1.26

Comments

@Doc94
Copy link

Doc94 commented Dec 23, 2024

Expected Behavior

The logger for pool status just print the log

Actual Behavior

Currently exists cases where that log also print a warning for a bad patter.

Steps to Reproduce

@Test
public void repoCase() {

}

Possible Solution

Fix the format in https://github.com/reactor/reactor-netty/blob/main/reactor-netty-core/src/main/java/reactor/netty/resources/PooledConnectionProvider.java

Your Environment

  • Reactor version(s) used: 2023.0.8
  • Other relevant libraries versions (eg. netty, ...): Netty
  • JVM version (java -version):
  • OS and version (eg. uname -a):
@Doc94 Doc94 added status/need-triage A new issue that still need to be evaluated as a whole type/bug A general bug labels Dec 23, 2024
@violetagg violetagg self-assigned this Dec 30, 2024
@violetagg violetagg added for/user-attention This issue needs user attention (feedback, rework, etc...) and removed status/need-triage A new issue that still need to be evaluated as a whole labels Dec 30, 2024
@violetagg
Copy link
Member

@Doc94 Please provide more details. Which is the log message that produces bad pattern?

@Doc94
Copy link
Author

Doc94 commented Dec 30, 2024

Hi, the message was like.

2024-12-22T12:51:26.846178Z reactor-http-nio-2 WARN found 4 argument placeholders, but provided 5 for pattern `[9eca61c3, L:/192.168.1.74:59917 - R:discord.com/162.159.138.232:443] {}, now: {} active connections, {} inactive connections and {} pending acquire requests.
```

@violetagg violetagg removed the for/user-attention This issue needs user attention (feedback, rework, etc...) label Dec 30, 2024
@raccoonback
Copy link
Contributor

@violetagg
Hello!
May I take charge of this issue and work on resolving it? 😊

raccoonback added a commit to raccoonback/reactor-netty that referenced this issue Dec 30, 2024
@raccoonback
Remove unnecessary conditional statements in log
a5a5b98 
fix: reactor#3561
@raccoonback raccoonback mentioned this issue Dec 30, 2024
Merged
@violetagg
Copy link
Member

@violetagg Hello! May I take charge of this issue and work on resolving it? 😊

sure, thanks

@violetagg violetagg added this to the 1.1.26 milestone Dec 30, 2024
violetagg added a commit that referenced this issue Jan 2, 2025
@raccoonback @violetagg
Generate log message in advance (#3571)
2bca537 
Add separate handling for Throwable when available.

Fixes: #3561

Co-authored-by: Violeta Georgieva <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@violetagg violetagg

Labels
type/bug A general bug
Projects
None yet
Milestone
1.1.26
Development

Successfully merging a pull request may close this issue.

Generate log message in advance raccoonback/reactor-netty
3 participants
@violetagg @Doc94 @raccoonback