GetContentAsAsync - Add CancellationToken

[bednart]

Hi, is there any reason why there is no CancellationToken argument in GetContentAsAsync method?

FromHttpContentAsync method which is called inside accepts CancellationToken.

In my opinion GetContentAsAsync should look like this.

public async Task<T?> GetContentAsAsync<T>(CancellationToken cancellationToken = default) => HasContent ?
  await RefitSettings.ContentSerializer.FromHttpContentAsync<T>(new StringContent(Content!), cancellationToken).ConfigureAwait(false) :
  default;

Do you agree?

Thanks,
beda

[anaisbetts]

I'm like 85% sure that the content of the HTTP request has already been downloaded here afaik, there is no practical reason to support cancellation because it's effectively just parsing a buffer. Error responses are also typically very small, and if they're not, I would argue that the server is Doing It Wrong

[bednart]

Yeah error responses should be small but still I think it would be better to add CancellationToken cancellationToken = default as argument add pass it to FromHttpContentAsync method. Even for that remaining 15 % :) And if you dont want to use it you do not have to.

[anaisbetts]

I disagree!