Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deduper feature to the bot #17

Closed
wants to merge 10 commits into from

Conversation

rafaelalmeidatk
Copy link
Member

@rafaelalmeidatk rafaelalmeidatk commented Jul 16, 2019

If a message is duplicated in one of the channels listed, the bot will delete the message and send a DM to the user. I need opinions on the time to forgive the cross-post (currently 2 minutes) and the DM message (that I literally copied from the jobs module hehe). Currently, the bot only reacts to the #general, #need-help-0 and #need-help-1 channels.

Closes #15

Copy link
Member

@vcarl vcarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a stab at this!!

features/deduper.js Outdated Show resolved Hide resolved
features/deduper.js Outdated Show resolved Hide resolved
@bpas247
Copy link
Member

bpas247 commented Oct 17, 2019

What's preventing this from being merged? Any current issues with the implementation?

@BTMPL
Copy link
Member

BTMPL commented Oct 17, 2019

What's preventing this from being merged? Any current issues with the implementation?

Hi there. Honestly, I've been away for some time and didn't have time to look into the PRs. I'll check this one and the new one in the next 48h.

I remember we recently merged something that broke the commands but I believe it was reverted.

@vcarl
Copy link
Member

vcarl commented Oct 17, 2019

Yep just got some new motion on it, intending to review it in the next few days.

@bpas247
Copy link
Member

bpas247 commented Oct 17, 2019

I remember we recently merged something that broke the commands but I believe it was reverted.

I'm guessing you're referring to my PR? 👀

@TrevorSayre
Copy link
Member

TrevorSayre commented Nov 19, 2019

@rafaelalmeidatk taking a look at this to see if I can help get it through

@TrevorSayre
Copy link
Member

This will also need to post to the channel #mod-log with the message:

Warned ${user} for crossposting

// prettier-ignore
msg.author
.send(`Hello there! It looks like you just posted a message to the #${msg.channel.name} channel on our server.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this whitespace intentional?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would imagine it's there to add some spacing between each section of text.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, similar to the message of #jobs channel

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You specifically need three tabs? It can't be just a newline?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I didn't even notice it lol
Thanks for pointing out, I removed it

nickserv added a commit that referenced this pull request Jan 31, 2020
This is an interim solution to something more automated like #17.
Base automatically changed from master to main January 22, 2021 23:29
@vcarl
Copy link
Member

vcarl commented Aug 19, 2024

It's been 5 years 😔 closing this. The core idea is solid but I think the exact behavior is a bit of a bikeshed problem — seems to be tricky to get consensus on how to respond

@vcarl vcarl closed this Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dedupe cross-posts
5 participants