-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deduper feature to the bot #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking a stab at this!!
What's preventing this from being merged? Any current issues with the implementation? |
Hi there. Honestly, I've been away for some time and didn't have time to look into the PRs. I'll check this one and the new one in the next 48h. I remember we recently merged something that broke the commands but I believe it was reverted. |
Yep just got some new motion on it, intending to review it in the next few days. |
I'm guessing you're referring to my PR? 👀 |
@rafaelalmeidatk taking a look at this to see if I can help get it through |
This will also need to post to the channel
|
features/deduper.js
Outdated
// prettier-ignore | ||
msg.author | ||
.send(`Hello there! It looks like you just posted a message to the #${msg.channel.name} channel on our server. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this whitespace intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would imagine it's there to add some spacing between each section of text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, similar to the message of #jobs
channel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You specifically need three tabs? It can't be just a newline?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I didn't even notice it lol
Thanks for pointing out, I removed it
This is an interim solution to something more automated like #17.
It's been 5 years 😔 closing this. The core idea is solid but I think the exact behavior is a bit of a bikeshed problem — seems to be tricky to get consensus on how to respond |
If a message is duplicated in one of the channels listed, the bot will delete the message and send a DM to the user. I need opinions on the time to forgive the cross-post (currently 2 minutes) and the DM message (that I literally copied from the
jobs
module hehe). Currently, the bot only reacts to the#general
,#need-help-0
and#need-help-1
channels.Closes #15