Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Use vim.notify #117

Open
jesse-c opened this issue May 26, 2022 · 3 comments
Open

Feature request: Use vim.notify #117

jesse-c opened this issue May 26, 2022 · 3 comments

Comments

@jesse-c
Copy link

jesse-c commented May 26, 2022

Often I'll start a test and then do something else while I wait. It would be helpful to have a notification pop-up so that I know whether it succeeded and I can move on or it failed and I need to go back to that test.

I'd be happy to try and implement this if I could get some starting points on where to do so.

@rcarriga
Copy link
Owner

rcarriga commented Jun 3, 2022

I'm not opposed to the idea but also not sure how it would look. Would it only be for failures? If not then I'd imagine it would get quite noisy. How would it look for multiple tests running at once?

@jesse-c
Copy link
Author

jesse-c commented Jun 6, 2022

I suppose it could be configurable if for passes and/or failures? Either one brings in that scenario where there's multiple tests running at once.

Since if n > 1 tests are being run, they can finish at n different times. For the current running tests, it could block on sending a notification until all current running tests are finished, and then send a combined notification? This brings up other scenarios, like if you start another test while some are already running. It could either add that to the list of running tests and still wait for the slowest?

@rcarriga
Copy link
Owner

rcarriga commented Jun 9, 2022

With the release of https://github.com/rcarriga/neotest, I'm going to consider this a feature request for the repo as I'll not really be contributing more to vim-ultest myself except for bug fixes. Since neotest expands on vim-ultests features and this is NeoVim only feature request I don't think there's any reason to stick to vim-ultest for users either

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants