Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importmap update removes pins via http #242

Closed
DalenW opened this issue Feb 5, 2024 · 1 comment
Closed

Importmap update removes pins via http #242

DalenW opened this issue Feb 5, 2024 · 1 comment

Comments

@DalenW
Copy link

DalenW commented Feb 5, 2024

If I have this pinned: pin "@popperjs/core", to: "https://ga.jspm.io/npm:@popperjs/[email protected]/lib/index.js" and then run ./bin/importmap update, it will remove the url and instead pin it from disk by changing the line to pin "@popperjs/core", to: "@popperjs--core.js" # @2.11.8. Issue this that this completly breaks popperjs functionality. It's required for bootsrap.

Updating the pin's link to the latest version does prevent the update, but it shouldn't break the pin altogether when running update. You can probably close this right away if that's by design.

@Caleb-T-Owens
Copy link
Contributor

Caleb-T-Owens commented Feb 7, 2024

This is a known issue with vendoring and should be resolved by #235

The reason why its being vendored is that the option to pin a CDN URL was removed in version 2

@DalenW DalenW closed this as completed Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants