Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't match Adwaita's border radius #405

Open
SeaDve opened this issue Jun 18, 2022 · 7 comments
Open

Doesn't match Adwaita's border radius #405

SeaDve opened this issue Jun 18, 2022 · 7 comments
Labels

Comments

@SeaDve
Copy link
Contributor

SeaDve commented Jun 18, 2022

firefox-gnome-theme:
image

Adwaita:
image

@rafaelmardojai
Copy link
Owner

Right now we're using the value given by -moz-gtk-csd-titlebar-radius, so should be the GTK3 radius.

I tried to fix this the other day but always got artifacts, will try again later when I have more free time.

@rafaelmardojai rafaelmardojai added the enhancement New feature or request label Jun 18, 2022
@polyjitter
Copy link

To be clear, is it still impossible to round bottom corners?

@CleoMenezesJr
Copy link
Collaborator

To be clear, is it still impossible to round bottom corners?

image
The implementation of the theme is through userchrome.css, basically visual changes are made with CSS and this implies that we cannot modify how the window is drawn on the screen.The most I managed to do was round the corners of the Appcontent, but the window will still be from behind.I've seen some people managing to put rounded corners with Mutter-Rounded, but many report artifacts.

@polyjitter
Copy link

polyjitter commented Jul 16, 2022 via email

@rafaelmardojai rafaelmardojai added upstream and removed enhancement New feature or request labels Oct 9, 2022
@ceiphr
Copy link

ceiphr commented Oct 22, 2022

Hello!

The best solution I've seen is to use this gnome shell extension:
https://github.com/yilozt/rounded-window-corners

IIRC It's developed by the same person behind Mutter-Rounded and doesn't seem to have artifacting issues (from my experience).

@aadilayub
Copy link

I've been using the rounded window corners extension linked above and the border rounding, shadows, window chrome of firefox in general is now indistinguishable from GNOME Web and other libadwaita apps. Much better approach than using CSS.

@Kimiblock
Copy link

Kimiblock commented Nov 14, 2023

Setting GTK theme to adw-gtk3 should be enough.

image

Rounded bottom borders can be enabled with widget.gtk.rounded-bottom-corners.enabled, be aware that this option has some minor bugs.

EDIT: When there is any blurred objects on a website, rounded corners will disappear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants