Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Libadwaita] Save/edit bookmark menu looks wrong #386

Closed
proninyaroslav opened this issue May 21, 2022 · 3 comments
Closed

[Libadwaita] Save/edit bookmark menu looks wrong #386

proninyaroslav opened this issue May 21, 2022 · 3 comments

Comments

@proninyaroslav
Copy link

Here is what I found (latest beta branch):
2022-05-21 20-46-20

  • No padding
  • Wrong text color of the Remove bookmark button
  • Strange looking dropdown arrows
  • New folder button doesn't have libadwaita style (screenshot below)

New folder

@proninyaroslav
Copy link
Author

proninyaroslav commented May 21, 2022

Sorry, I got this on the master branch and it seems that part of the problem is solved. The following problems remain:

  • Strange looking dropdown arrows
  • New folder button doesn't have libadwaita style

There are also problems in the bookmarks menu:

  • Wrong arrows
    2022-05-21 21-03-36
  • Wrong search bar padding
    2022-05-21 21-04-57

@CleoMenezesJr
Copy link
Collaborator

CleoMenezesJr commented May 21, 2022

Bookmark

Duplicate #381, it was fixed

New folder button doesn't have libadwaita style (screenshot below)

Personally, I haven't tried to customize it yet, but I believe that Rafael has some reason to be like that.

Wrong arrows

Quite weird. This arrow is not used in the theme, have you tried deleting the folder and re-installing F-G-T from scratch?

Wrong search bar padding

This has not yet been touched, but we are aware.

rafaelmardojai added a commit that referenced this issue May 22, 2022
related to #386

Signed-off-by: Rafael Mardojai CM <[email protected]>
rafaelmardojai added a commit that referenced this issue May 22, 2022
related to #386

Signed-off-by: Rafael Mardojai CM <[email protected]>
@rafaelmardojai
Copy link
Owner

rafaelmardojai commented May 22, 2022

Sorry, forgot to rebase beta, should be update now.

  • Strange looking dropdown arrows
  • New folder button doesn't have libadwaita style

Fixed.

There are also problems in the bookmarks menu:

This is he Library window, so opened a new issue (#387).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants